-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @parcel/watcher
#1269
base: fix/recursive-symlinks
Are you sure you want to change the base?
Bump @parcel/watcher
#1269
Conversation
4f86516
to
3d5c551
Compare
72413a4
to
3d6c5db
Compare
8ba0a0f
to
a20d46d
Compare
4dd28cd
to
d6c204b
Compare
This already works and is probably already tested but wanted to add a more explicit test to detect it.
d6c204b
to
0cbc1ae
Compare
ef2cfbb
to
e0dcb16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind including some context as to why this is necessary or if this is just a general version bump etc?
/** The "cwd" for this test */ | ||
root: string | ||
|
||
/** The "cwd" for this test */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste error? I think root
is already the "cwd"
for this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swore I fixed this lol thanks will update
Done. Yeah, it's just a general version bump since we're suuuuuuper behind. It was born out of triaging an issue that I thought was parcel watcher related but it ended up that it wasn't. |
This is just a general version bump. I thought an issue was parcel watcher related but turned out not to be. Saw we were very behind so I wanted to make sure we were up to date.