Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @parcel/watcher #1269

Open
wants to merge 12 commits into
base: fix/recursive-symlinks
Choose a base branch
from

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Mar 18, 2025

This is just a general version bump. I thought an issue was parcel watcher related but turned out not to be. Saw we were very behind so I wanted to make sure we were up to date.

@thecrypticace thecrypticace marked this pull request as draft March 18, 2025 13:45
@thecrypticace thecrypticace force-pushed the feat/bump-parcel-watcher branch from 4f86516 to 3d5c551 Compare March 20, 2025 19:45
@thecrypticace thecrypticace changed the base branch from main to fix/recursive-symlinks March 20, 2025 19:46
@thecrypticace thecrypticace force-pushed the fix/recursive-symlinks branch 3 times, most recently from 72413a4 to 3d6c5db Compare March 22, 2025 18:28
@thecrypticace thecrypticace force-pushed the feat/bump-parcel-watcher branch 2 times, most recently from 8ba0a0f to a20d46d Compare March 22, 2025 18:46
@thecrypticace thecrypticace force-pushed the fix/recursive-symlinks branch 2 times, most recently from 4dd28cd to d6c204b Compare March 27, 2025 17:30
@thecrypticace thecrypticace force-pushed the fix/recursive-symlinks branch from d6c204b to 0cbc1ae Compare March 31, 2025 18:44
@thecrypticace thecrypticace force-pushed the feat/bump-parcel-watcher branch 2 times, most recently from ef2cfbb to e0dcb16 Compare March 31, 2025 19:21
@thecrypticace thecrypticace marked this pull request as ready for review March 31, 2025 19:21
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind including some context as to why this is necessary or if this is just a general version bump etc?

/** The "cwd" for this test */
root: string

/** The "cwd" for this test */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste error? I think root is already the "cwd" for this test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swore I fixed this lol thanks will update

@thecrypticace
Copy link
Contributor Author

Mind including some context as to why this is necessary or if this is just a general version bump etc?

Done. Yeah, it's just a general version bump since we're suuuuuuper behind. It was born out of triaging an issue that I thought was parcel watcher related but it ended up that it wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants