Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Improve DX around completions when prefixes are in use #1292

Merged
merged 3 commits into from
Apr 4, 2025
Merged

v4: Improve DX around completions when prefixes are in use #1292

merged 3 commits into from
Apr 4, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Apr 1, 2025 •
edited
Loading

Fixes #1291

  • Really needs tests

@thecrypticace thecrypticace force-pushed the fix/better-prefix-behavior branch from 8ee24c5 to d650a8c Compare April 3, 2025 19:56
@thecrypticace thecrypticace marked this pull request as ready for review April 3, 2025 19:56
RobinMalfait
RobinMalfait approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little funny that it's & but sure.

Has a prefix: ✅
image

And in the HTML: ✅
image

Once you have the prefix typed, no more prefix: ✅
image

And in the HTML: ✅
image

Tested with my name to make sure we didn't accidentally hardcode tw :D

@thecrypticace
Copy link
Contributor Author

brb changing all my old projects with a prefix to use robin: 😂

@thecrypticace thecrypticace merged commit 6c573a8 into main Apr 4, 2025
12 checks passed
@thecrypticace thecrypticace deleted the fix/better-prefix-behavior branch April 4, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DX issue: Using a prefix in v4 requires two actions for a completion
2 participants
@thecrypticace @RobinMalfait