-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update v3 theme docs to use proper branch in URLs #2169
Open
joeyfigaro
wants to merge
3
commits into
tailwindlabs:v3
Choose a base branch
from
joeyfigaro:patch-2
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: HTML Element is missing end tag. solution: Corrected typo where the "/" character was missing in the end-tag.
this should hopefully fix issues in [original PR](tailwindlabs#2168) I didn't see any other v3.* branches, so hopefully `v3.3` is the correct branch to address this (and point to for public documentation.) This fixes an issue in the `version < 4.x` docs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.) --- ### Reproducing 1. Visit [tailwindcss.com/docs](https://tailwindcss.com/docs) 2. Select `v3.4.17` in the top-left version dropdown 3. Click `Get started` 4. Click the `Customization > Theme` link in left-hand nav 5. Search for `the default theme configuration` and click one of the resulting links 6. Observe redirect to [a (no longer existing) blob in Github](https://github.com/tailwindlabs/tailwindcss/blob/main/stubs/config.full.js)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @philipp-spiess – thanks for trying a redeploy. Do you have any insights here? I'm unable to view the deployment details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should hopefully fix issues in original PR
I didn't see any other v3.* branches, so hopefully
v3.3
is the correct branch to address this (and point to for public documentation.)This fixes an issue in the
version < 4.x
docs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.)Reproducing
v3.4.17
in the top-left version dropdownGet started
Customization > Theme
link in left-hand navthe default theme configuration
and click one of the resulting links