Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update v3 theme docs to use proper branch in URLs #2169

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from

Conversation

joeyfigaro
Copy link

this should hopefully fix issues in original PR

I didn't see any other v3.* branches, so hopefully v3.3 is the correct branch to address this (and point to for public documentation.)

This fixes an issue in the version < 4.x docs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.)


Reproducing

  1. Visit tailwindcss.com/docs
  2. Select v3.4.17 in the top-left version dropdown
  3. Click Get started
  4. Click the Customization > Theme link in left-hand nav
  5. Search for the default theme configuration and click one of the resulting links
  6. Observe redirect to a (no longer existing) blob in Github

mekraldi and others added 2 commits May 23, 2024 14:59
issue: HTML Element is missing end tag.
solution: Corrected typo where the "/" character was missing in the end-tag.
this should hopefully fix issues in [original PR](tailwindlabs#2168)

I didn't see any other v3.* branches, so hopefully `v3.3` is the correct branch to address this (and point to for public documentation.)

This fixes an issue in the `version < 4.x` docs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.)

---

### Reproducing

1. Visit [tailwindcss.com/docs](https://tailwindcss.com/docs)
2. Select `v3.4.17` in the top-left version dropdown
3. Click `Get started`
4. Click the `Customization > Theme` link in left-hand nav
5. Search for `the default theme configuration` and click one of the resulting links
6. Observe redirect to [a (no longer existing) blob in Github](https://github.com/tailwindlabs/tailwindcss/blob/main/stubs/config.full.js)
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-com ❌ Failed (Inspect) Mar 25, 2025 0:28am

@philipp-spiess philipp-spiess changed the base branch from v3.3 to v3 March 25, 2025 12:24
@joeyfigaro
Copy link
Author

Hey @philipp-spiess – thanks for trying a redeploy. Do you have any insights here? I'm unable to view the deployment details.

@joeyfigaro joeyfigaro changed the title docs: update v3.3 theme docs to use proper branch in URLs docs: update v3 theme docs to use proper branch in URLs Mar 28, 2025
@philipp-spiess
Copy link
Member

Yep sure sorry I want to look into it and make it work but didn't get around to it. Seems like some dependency mismatch that needs to be fixed (awkwardly caused by our own dependencies hahaha)

Screenshot 2025-03-28 at 18 06 09

@joeyfigaro
Copy link
Author

Yep sure sorry I want to look into it and make it work but didn't get around to it. Seems like some dependency mismatch that needs to be fixed (awkwardly caused by our own dependencies hahaha)

Screenshot 2025-03-28 at 18 06 09

All good! I'll keep checking back in on things to see where everything's at. Maybe I could look into things as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants