Remove bare value support for translate utilities
#13289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be handled by bare values without issues.
- In case of `columns`, bare values can be used for the amount of columns - In case of `divide-width`, we can always look at `--border-width`
adamwathan
reviewed
Mar 20, 2024
| @@ -1901,14 +1878,12 @@ export function createUtilities(theme: Theme) { | |||
| suggest('grid-cols', () => [ | |||
| { | |||
| values: Array.from({ length: 12 }, (_, i) => `${i + 1}`), | |||
| valueThemeKeys: ['--grid-template-columns'], | |||
There was a problem hiding this comment.
We still need all of these theme keys for backwards compatibility, that's why these all exist right now 👍
adamwathan
reviewed
Mar 20, 2024
| @@ -3524,6 +3500,9 @@ export function createUtilities(theme: Theme) { | |||
| }) | |||
|
|
|||
| functionalUtility('backdrop-opacity', { | |||
| // TODO: Do we want to remove this or not? Named opacity utilities (apart | |||
| // form like `opacity-disabled` do not make a lot of sense). Just bare | |||
| // values make more sense. | |||
There was a problem hiding this comment.
Motivation is backwards compatibility for anyone who had something like opacity-backdrop defined in their config. I don't think we'd really document these theme keys going forward but we're going to have to re-introduce all this stuff for BC if we get rid of it I think.
KrisBraun
approved these changes
Mar 20, 2024
RobinMalfait
changed the title
translate utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes bare value support for the
translateutilities.For example,
translate-x-48would pick48from the theme, which maps to12rem, buttranslate-x-50doesn't exist in the theme, so it would just use bare values and in this case it would map to50%.