Correctly migrate leading-*
classes
#16004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the upgrade tool by properly migrating the
leading-[<number>]
classes.The issue is that
leading-[<number>]
maps to the number directly, but if you use a bare value, then it's a multiplier for based on the--spacing
value.E.g.:
leading-[2]:
leading-2:
This PR will now prevent migrating arbitrary values to bare values for
leading-*
utilities.That said, this does introduce a small improvement where
leading-[1]
is migrated toleading-none
.Fixes: #15924