Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding a warning in the upgrade CLI when a config file contains non-migratable values. #16113

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat: Adding a warning in the upgrade CLI when a config file contains non-migratable values. #16113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f9790d
feat: adding warning for non-migratable values in in upgrade cli
Jan 31, 2025
cf8c4ad
update CHANGELOG
Jan 31, 2025
a4d77cd
update CHANGELOG
Jan 31, 2025
81a01d3
update CHANGELOG
Jan 31, 2025
1c8645a
renaming var to extraKeys
Jan 31, 2025
01127be
Merge branch 'main' into warning-non-migratable
baptisthecht Jan 31, 2025
352799a
Merge branch 'main' into warning-non-migratable
baptisthecht Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Refactor gradient implementation to work around [prettier/prettier#17058](https://github.com/prettier/prettier/issues/17058) ([#16072](https://github.com/tailwindlabs/tailwindcss/pull/16072))
- Vite: Ensure hot-reloading works with SolidStart setups ([#16052](https://github.com/tailwindlabs/tailwindcss/pull/16052))
- Vite: Fix a crash when starting the development server in SolidStart setups ([#16052](https://github.com/tailwindlabs/tailwindcss/pull/16052))
- Adding a warning in the upgrade CLI when a config file contains non-migratable values. ([#16113](https://github.com/tailwindlabs/tailwindcss/pull/16113))
- Prevent camelCasing CSS custom properties added by JavaScript plugins ([#16103](https://github.com/tailwindlabs/tailwindcss/pull/16103))
- Vite: Don't rebase URLs that appear to be aliases ([#16078](https://github.com/tailwindlabs/tailwindcss/pull/16078))
- Vite: Transform `<style>` blocks in HTML files ([#16069](https://github.com/tailwindlabs/tailwindcss/pull/16069))
- Prevent camel-casing CSS custom properties added by JavaScript plugins ([#16103](https://github.com/tailwindlabs/tailwindcss/pull/16103))
Expand Down
2 changes: 2 additions & 0 deletions packages/@tailwindcss-upgrade/src/migrate-js-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ function canMigrateConfig(unresolvedConfig: Config, source: string): boolean {
]

if (Object.keys(unresolvedConfig).some((key) => !knownProperties.includes(key))) {
let extraKeys = Object.keys(unresolvedConfig).filter(key => !knownProperties.includes(key))
info(`We have detected that your configuration file contains non-migratable values : ${highlight(extraKeys.join(', '))}`, { prefix: '↳ ' })
return false
}

Expand Down