Ensure @import url(…)
is hoisted
#16203
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if you use
@import url(…);
after the@import "tailwindcss";
, then invalid CSS is being generated.This is because the
@import "tailwindcss";
directive is being replaced with the actual generated CSS variables, utilities, etc. but the@import url(…);
is kept as-is (Tailwind CSS doesn't handle these). This means that in the final CSS the@import url(…)
could be in the middle of the generated CSS which is invalid.While the above examples should both work from a CSS perspective, this PR makes sure to hoist the
@import url(…);
rules. All non-external imports will be inlined already.Once this PR is merged, both these situations are valid:
In order to do this correctly, we also have to make sure that the license comment and
@charset
is in the correct spot.Test plan