Ensure first argument to var(…) still unescapes \_
#16206
Merged
+157
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
reviewed
Feb 4, 2025
Co-authored-by: Robin Malfait <[email protected]>
RobinMalfait
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16170
This PR fixes an issue where the previously opted-out escaping of the first argument for the
var(…)function was not unescaped at all. This was introduced in #14776 where the intention was to not require escaping of underscores in the var function (e.g.ml-[var(--spacing-1_5)]). However, I do think it still makes sense to unescape an eventually escaped underline for consistency.Test plan
The example from #1670 now parses as expected: