Skip to content

fix: failure to deserialize native icon - #36

Merged
takassh merged 3 commits into
takassh:mainfrom
generalvamp:fix/failure-to-deserialize-native-icon
Apr 20, 2026
Merged

takassh merged 3 commits into
takassh:mainfrom
generalvamp:fix/failure-to-deserialize-native-icon

Conversation

@generalvamp

Copy link
Copy Markdown
Contributor

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

@ELLIOTTCABLE

Copy link
Copy Markdown
Contributor

This only handled page, not the rest of the interfaces.

Opened a PR on your PR propagating the fix to all the relevant types:

generalvamp#1

@takassh

takassh commented Apr 19, 2026

Copy link
Copy Markdown
Owner

@generalvamp @ELLIOTTCABLE
Thank you for your contributions!

Can you please merge generalvamp#1 on your repository? @generalvamp

Further propagate icon-deser changes
@generalvamp

Copy link
Copy Markdown
Contributor Author

yes, good catch on the other types. @ELLIOTTCABLE
it has been merged on my fork

@takassh
takassh merged commit d0048db into takassh:main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants