Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR-23282] [JS Library] Add a possibility to pass sub_choise for Person with Origin #356

Merged
merged 6 commits into from
Feb 5, 2025
Merged

[PR-23282] [JS Library] Add a possibility to pass sub_choise for Person with Origin #356

merged 6 commits into from
Feb 5, 2025

Conversation

bohdan-perekhrest
Copy link
Contributor

BE: here

Related Stories

max-si-m
max-si-m requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@max-si-m max-si-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also what about authenticate_customer calls don't they support opt-in options?

@bohdan-perekhrest
Copy link
Contributor Author

also what about authenticate_customer calls don't they support opt-in options?

it has phone_optin and gated_param_subscribed as sub_choice

dgtv
dgtv requested changes Jan 24, 2025
View reviewed changes
@bohdan-perekhrest bohdan-perekhrest added the LG Looks good label Jan 27, 2025
@bohdan-perekhrest bohdan-perekhrest merged commit c852cba into master Feb 5, 2025
2 checks passed
@bohdan-perekhrest bohdan-perekhrest deleted the perekhrest-pr-23282 branch February 5, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgtv dgtv dgtv approved these changes

@max-si-m max-si-m max-si-m approved these changes

Assignees

@max-si-m max-si-m

Labels
LG Looks good
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bohdan-perekhrest @dgtv @max-si-m