Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Service impl for ApiRouter generic #143

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Make the Service impl for ApiRouter generic #143

merged 2 commits into from
Dec 21, 2024

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Jun 25, 2024

This aligns the signature of impl Service for ApiRouter to be the same as impl Service for axum::Router

@elichai
Copy link
Contributor Author

elichai commented Sep 8, 2024

Ping @tamasfe

@2vg 2vg mentioned this pull request Oct 29, 2024
Merged
@JakkuSakura JakkuSakura merged commit 1cf82a9 into tamasfe:master Dec 21, 2024
1 check passed
@elichai elichai deleted the service branch January 14, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iftachFridental iftachFridental iftachFridental approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elichai @iftachFridental @JakkuSakura