Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #160

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Remove unused dependencies #160

merged 1 commit into from
Dec 24, 2024

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Dec 22, 2024

… and collapse some lines in Cargo.tomls.

@jplatte jplatte requested a review from JakkuSakura December 22, 2024 18:50
@JakkuSakura
Copy link
Collaborator

  1. Should we put axum-jsonschema into its own repo?
  2. As aide is a library, it's better not to rely on specific patch version, as in major.minor.patch. It's a good time to clean them up

@jplatte
Copy link
Collaborator Author

jplatte commented Dec 24, 2024

  1. No idea, honestly. I don't care about it personally, so would probably default to doing nothing (keeping it here) for now. If you want to make a PR removing it from this repo, let's try to loop the original maintainers in for that decision?
  2. I disagree. Specifying a minor/patch version only restricts the minimum, not the maximum version. Since we're not testing the minimum version in CI, I'd rather not lower it. See also https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

@tamasfe
Copy link
Owner

tamasfe commented Dec 24, 2024

Should we put axum-jsonschema into its own repo?

#162, if it was up to me, I'd just move it to an archived repo and update the crates.io package with a notice.

@JakkuSakura
Copy link
Collaborator

I disagree. Specifying a minor/patch version only restricts the minimum, not the maximum version. Since we're not testing the minimum version in CI, I'd rather not lower it.

I know this rule. I just had some crazy dependencies that specified =patch version. If they're incompatible, it's tricky to deal with them

Copy link
Collaborator

@JakkuSakura JakkuSakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deal with axum-jsonschema in another PR

@jplatte jplatte merged commit 4b1b325 into master Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants