IOS-8687 New failed offline attestation flow #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Dec 20, 2024
| @@ -25,6 +26,7 @@ enum EmailType { | |||
| return subject | |||
| case .failedToPushTx: return Localization.feedbackSubjectTxPushFailed | |||
| case .activatedCard: return Localization.feedbackSubjectPreActivatedWallet | |||
| case .attestationFailed: return "Card attestation failed" | |||
There was a problem hiding this comment.
Думаю не стоит вообще темы писем переводить, это же неудобно анализировать
tureck1y
commented
Dec 20, 2024
| @@ -192,6 +192,8 @@ extension Analytics { | |||
|
|
|||
| case onboardingSeedScreenCapture = "[Onboarding / Seed Phrase] Screen Capture" | |||
|
|
|||
| case onboardingOfflineAttestationFailed = "[Onboarding] Offline Attestation Failed" | |||
There was a problem hiding this comment.
группа такая, хоть это и не только на онбординге может быть
tureck1y
commented
Dec 20, 2024
| return Just(UserWalletRepositoryResult.error(error)) | ||
| default: | ||
| failedCardScanTracker.recordFailure() |
There was a problem hiding this comment.
не трекаем, а сразу показываем ошибку
tureck1y
commented
Dec 20, 2024
| @@ -90,24 +90,3 @@ enum UserWalletRepositoryUnlockMethod { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| enum UserWalletRepositoryError: String, Error, LocalizedError, BindableError { | |||
There was a problem hiding this comment.
унес без изменений логики
tureck1y
commented
Dec 20, 2024
| @@ -15,10 +15,6 @@ class AppPresenter { | |||
|
|
|||
| private init() {} | |||
|
|
|||
| func showError(_ error: Error) { | |||
There was a problem hiding this comment.
не использовалось больше
tureck1y
commented
Dec 20, 2024
| } | ||
|
|
||
| extension BindableError where Self: Error { |
There was a problem hiding this comment.
из-за этого были проблемы, которые можно увидеть в DetailsViewModel, отрефачил на более простой и очевидный подход
ba1ashov
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Если оффлайн аттестация зафейлилась, то не даем больше продолжать даже на свой страх и риск.
небольшой рефак и чистка неиспользуемого кода
в сдк обновились строки и были изменения
tangem/tangem-sdk-ios@5f6d3eb
IOS-8687 Do not continue failed offline attestation tangem-sdk-ios#389