Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-8687 Do not continue failed offline attestation #389

Merged
merged 1 commit into from
Dec 20, 2024
Merged

IOS-8687 Do not continue failed offline attestation #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions TangemSdk/TangemSdk/Operations/Attestation/AttestationTask.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,9 @@ public final class AttestationTask: CardSessionRunnable {
self.currentAttestationStatus.cardKeyAttestation = .verifiedOffline
self.continueAttestation(session, completion)
case .failure(let error):
//Card attestation failed. Update status and continue attestation
//Card attestation failed. Update status and fail attestation
if case TangemSdkError.cardVerificationFailed = error {
self.currentAttestationStatus.cardKeyAttestation = .failed
self.continueAttestation(session, completion)
return
}

completion(.failure(error))
Expand Down Expand Up @@ -87,11 +85,9 @@ public final class AttestationTask: CardSessionRunnable {
self.currentAttestationStatus.walletKeysAttestation = hasWarnings ? .warning : .verified
self.runExtraAttestation(session, completion)
case .failure(let error):
//Wallets attestation failed. Update status and continue attestation
//Wallets attestation failed. Update status and fail attestation
if case TangemSdkError.cardVerificationFailed = error {
self.currentAttestationStatus.walletKeysAttestation = .failed
self.runExtraAttestation(session, completion)
return
}

completion(.failure(error))
Expand Down
2 changes: 1 addition & 1 deletion TangemSdk/TangemSdk/UI/Main/DefaultSessionViewDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ extension DefaultSessionViewDelegate: SessionViewDelegate {
return
}

let title = TangemSdkError.cardVerificationFailed.localizedDescription
let title = "attestation_failed_card_title".localized
let message = isDevelopmentCard ? "attestation_failed_dev_card".localized
: "attestation_failed_card".localized
let tint = style.colors.tintUIColor
Expand Down
Loading