Dynamic anchors #893

hjanetzek · 2016-08-02T17:25:56Z

Continuing #842

Since the changes of tile-label-placement branch introduced incremental collision testing it's possible to try fallback anchors directly instead of going through the fallbacks during multiple frames.

TODO

When the parent label has multiple anchors the child label must be updated() after the parent has been placed
Bug in alignFromParent where the parent's offset is constantly added to childs m_offset
Should offset for child labels be ignored since it conflicts the offset from the parent?

BUGS

icon:text:transition [show,hide] time: form is not parsed correctly (old bug)

- So anchor fallback state would be able to switch between different text alignments

squash: cleaups fix: don't move out textRanges

- don't apply anchor offset in updateScreenTransform so that label.transform.state.screenPos can be reused while switching anchors - make sprite-quads relative to center (to be consistent with text labels)

tallytalwar · 2016-08-10T20:33:31Z

core/src/style/pointStyleBuilder.cpp

@@ -278,7 +278,7 @@ void PointStyleBuilder::addFeature(const Feature& _feat, const DrawRule& _rule)

        size_t textStart = textLabels.size();

-        textStyleBuilder.addFeatureCommon(_feat, _rule, true);
+        if (!textStyleBuilder.addFeatureCommon(_feat, _rule, true)) { return; }


tallytalwar · 2016-08-10T20:49:37Z

Updating fallback anchor on the same frame does improve the feeling of jumpiness/flickering labels we were seeing before. But its still noticeable. (try with bubble-wrap manhattan area). Might require some minor ironing here to get a crispy transitions. Otherwise code is fine.

Will play with it a bit more on bubble-wrap.

tallytalwar · 2016-08-10T21:16:55Z

core/src/scene/sceneLoader.cpp

@@ -560,7 +560,7 @@ std::shared_ptr<Texture> SceneLoader::fetchTexture(const std::string& name, cons
                auto ptr = (unsigned char*)(rawData.data());
                size_t dataSize = rawData.size();
                std::lock_guard<std::mutex> lock(m_textureMutex);
-				auto texture = scene->getTexture(name);
+                                auto texture = scene->getTexture(name);


nitpick, can you fix the indentation here? (also line# 807)

M-x whitespace-cleanup did replace tabs with spaces. @karimnaaji fix your editor! :p

Bubble Wrap v4.1.0 does use the proper anchor fallbacks now, but that
version is not yet used in Eraser Map the app (it’s pegged to v3.x).

On Wed, Aug 10, 2016 at 2:26 PM, Hannes Janetzek [email protected]
wrote:

In core/src/scene/sceneLoader.cpp
#893 (comment):

@@ -560,7 +560,7 @@ std::shared_ptr SceneLoader::fetchTexture(const std::string& name, cons
auto ptr = (unsigned char*)(rawData.data());
size_t dataSize = rawData.size();
std::lock_guardstd::mutex lock(m_textureMutex);

auto texture = scene->getTexture(name);

auto texture = scene->getTexture(name);

M-x whitespace-cleanup did replace tabs with spaces. @karimnaaji
https://github.com/karimnaaji fix your editor! :p

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram-es/pull/893/files/562f172b3d217c7fcbdd754bb5d0102a0e681b0c#r74334094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO7xuIFHvnlY_QmQnmWk2qgWBb8ovks5qekIKgaJpZM4Ja2Xw
.

Nice! looking good - even though I'm more in favor of four point-placement for better icon-text association :)

@varun: of course there is now more jumping as anchor fallbacks are not coordinated between zoom-levels. definitely something to investigate in future

Oh, wrong thread..

hjanetzek · 2016-08-10T21:23:58Z

Did you compare side-by-side eraser-map with master? Could be that you notice it now more while focusing on the labels. It should make no difference as eraser-map doesn't use anchor fallbacks, or does it now?

- this caused big label-clouds in tilted views

- always promote occlusion from previous frame when applying only transitions

hjanetzek · 2016-08-10T21:40:34Z

Last commit should improve labels flickering on zoom-level jumps when no transition effect is set

tallytalwar · 2016-08-15T14:59:33Z

I am fine with merging this now. Changing default to use 4 anchor points instead of 8 makes the transitioning much more smoother.

Going to merge this, if no one has any other issue?
@karimnaaji you would wanna look at some of the last changes here?

karimnaaji · 2016-08-15T15:15:39Z

@tallytalwar hold on this while I'm looking at the last changes.

karimnaaji · 2016-08-15T15:52:01Z

@hjanetzek are you aware of the issue exposed in this video? (look at "underground pizza" label). It seems that the fallback does not reset properly the fading transition.

Another thing I noticed; sometimes the fallback involves a fading transition, sometimes not, looking at this more closely.

hjanetzek · 2016-08-15T16:45:34Z

@karimnaaji I think this effect came from the newly added fade_out->fade_in state change. Which was also missing to reset the fade effect.

- needs more thought, fade_in time must match the current alpha

karimnaaji · 2016-08-15T17:05:55Z

All good to me here!

- fixes some child labels from not becoming visible on zoom-level switch

hjanetzek force-pushed the dynamic-anchors branch 3 times, most recently from c5ea68b to 39e0c2a Compare August 3, 2016 12:56

hjanetzek changed the title ~~[rfc] Dynamic anchors~~ Dynamic anchors Aug 3, 2016

hjanetzek added the ready for review label Aug 3, 2016

hjanetzek force-pushed the dynamic-anchors branch 7 times, most recently from aa66108 to c2c507b Compare August 8, 2016 18:14

hjanetzek mentioned this pull request Aug 8, 2016

Automatic label anchor (rebased) #842

Closed

7 tasks

karimnaaji and others added 17 commits August 9, 2016 12:04

Move align from anchor to label property

68e3b3f

Parse anchor fallbacks

f8dec54

Anchor fallback label state

bc56d7d

label:applyState early return on debug mode

4659ca6

Place holder for prefered initial placement

b0b88a7

save wip: Multiple layout

8377d17

Several text glyph range for instance of text label

c284be2

- So anchor fallback state would be able to switch between different text alignments

squash: Remove unused

2eba604

Switch current quad range when anchor is being updated

9b383de

Rename debug flag all_labels -> draw_all_labels

19ebcce

No need to test visibility for clipped labels

2074cb4

Reuse fade effect

510c882

wip: render line-labels again

3814ab0

cleanup: reorder some lines

53a8b0b

cleanup: shapes.size was checked before

14ca6df

fix: clear m_attributes.textRanges

e511e5b

simplify TextStyleBuilder::build

772828e

squash: cleaups fix: don't move out textRanges

improve fallback handling

0e4407f

- don't apply anchor offset in updateScreenTransform so that label.transform.state.screenPos can be reused while switching anchors - make sprite-quads relative to center (to be consistent with text labels)

hjanetzek force-pushed the dynamic-anchors branch from c2c507b to ba8d269 Compare August 9, 2016 10:10

tallytalwar reviewed Aug 10, 2016
View reviewed changes

hjanetzek added 4 commits August 10, 2016 23:30

fix: text transition style parsing

f9380de

also let fading-out labels fade back in

6fdf101

don't set labels directly to visible when coming into screen

56dc5c2

- this caused big label-clouds in tilted views

fix some flickering with label transitions:

9ea8b1b

- always promote occlusion from previous frame when applying only transitions

hjanetzek force-pushed the dynamic-anchors branch from 562f172 to 9ea8b1b Compare August 10, 2016 21:30

hjanetzek force-pushed the dynamic-anchors branch 2 times, most recently from 752fdfe to 576a870 Compare August 10, 2016 22:19

hjanetzek added 2 commits August 11, 2016 16:22

skip fade-in/out when transition time is 0

80a3801

changed default icon-text anchors to 4-point placement

ef66e63

hjanetzek force-pushed the dynamic-anchors branch from 576a870 to ef66e63 Compare August 11, 2016 14:22

improve sorting for screen-space label placement

a87e38d

hjanetzek force-pushed the dynamic-anchors branch from 960a779 to ea698ec Compare August 15, 2016 16:44

disable fade on fade_out->fade_in switch

e4f6e41

- needs more thought, fade_in time must match the current alpha

hjanetzek force-pushed the dynamic-anchors branch from ea698ec to e4f6e41 Compare August 15, 2016 16:47

fixup: only check if parent is occluded to occlude child

b87f22e

- fixes some child labels from not becoming visible on zoom-level switch

hjanetzek merged commit d8d76eb into master Aug 16, 2016

hjanetzek deleted the dynamic-anchors branch August 16, 2016 16:02

karimnaaji mentioned this pull request Aug 17, 2016

Label fading_out state is broken #886

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic anchors #893

Dynamic anchors #893

hjanetzek commented Aug 2, 2016 •

edited

Loading

tallytalwar Aug 10, 2016

tallytalwar commented Aug 10, 2016 •

edited

Loading

tallytalwar Aug 10, 2016

hjanetzek Aug 10, 2016

nvkelso Aug 10, 2016

hjanetzek Aug 10, 2016 •

edited

Loading

hjanetzek commented Aug 10, 2016

hjanetzek commented Aug 10, 2016

tallytalwar commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

hjanetzek commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

Dynamic anchors #893

Dynamic anchors #893

Conversation

hjanetzek commented Aug 2, 2016 • edited Loading

tallytalwar Aug 10, 2016

Choose a reason for hiding this comment

tallytalwar commented Aug 10, 2016 • edited Loading

tallytalwar Aug 10, 2016

Choose a reason for hiding this comment

hjanetzek Aug 10, 2016

Choose a reason for hiding this comment

nvkelso Aug 10, 2016

Choose a reason for hiding this comment

hjanetzek Aug 10, 2016 • edited Loading

Choose a reason for hiding this comment

hjanetzek commented Aug 10, 2016

hjanetzek commented Aug 10, 2016

tallytalwar commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

hjanetzek commented Aug 15, 2016

karimnaaji commented Aug 15, 2016

hjanetzek commented Aug 2, 2016 •

edited

Loading

tallytalwar commented Aug 10, 2016 •

edited

Loading

hjanetzek Aug 10, 2016 •

edited

Loading