Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #67

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Improvements #67

merged 1 commit into from
Apr 3, 2021

Conversation

tank-bohr
Copy link
Owner

Changes:

  • Lowercase method atoms
  • Use binaries both for header names and values
  • Introduce raw_headers which preserve headers case and order. erlang/otp#2466 allows to keep headers case
  • Some documentation updates
  • Update deps

Rationale:

  • maintenance
  • make the library more elixir friendly
  • more accurate work with headers

@tank-bohr tank-bohr force-pushed the minor_improvements branch 4 times, most recently from f885ff5 to 18caee8 Compare April 3, 2021 14:16
- Lowercase method atoms
- Use binaries both for header names and values
- Introduce `raw_headers` which preserve headers case and order. [erlang/otp#2466](erlang/otp#2466) allows to keep headers case
- Some documentation updates
- Update deps
- Update CI to run tests inside docker container
@tank-bohr tank-bohr force-pushed the minor_improvements branch from 18caee8 to 76e4e57 Compare April 3, 2021 14:30
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #67 (76e4e57) into master (a205a44) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   94.93%   95.15%   +0.22%     
==========================================
  Files          11       11              
  Lines         217      227      +10     
==========================================
+ Hits          206      216      +10     
  Misses         11       11              
Impacted Files Coverage Δ
src/bookish_spork_handler.erl 91.30% <100.00%> (+0.60%) ⬆️
src/bookish_spork_request.erl 100.00% <100.00%> (ø)
src/bookish_spork_server.erl 90.90% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a205a44...76e4e57. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant