Skip to content

Defaults changed by configuration #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Defaults changed by configuration #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76f443e
fix jshint errors
dhaub May 31, 2016
c3beaf5
Defaults getting changed by configuration due to shallow copy of defa…
dhaub May 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions test/wiredep_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,33 +6,9 @@
var fs = require('fs-extra');
var path = require('path');
var assert = require('chai').assert;
var wiredep;

require.uncache = function (moduleName) {
var mod = require.resolve(moduleName);
if (mod && ((mod = require.cache[mod]) !== undefined)) {
(function run(mod) {
mod.children.forEach(function (child) {
run(child);
});
delete require.cache[mod.id];
})(mod);
}

Object.keys(module.constructor._pathCache).forEach(function(cacheKey) {
if (cacheKey.indexOf(moduleName)>0) {
delete module.constructor._pathCache[cacheKey];
}
});
};
var wiredep = require('../wiredep');

describe('wiredep', function () {
beforeEach(function () {
wiredep = require('../wiredep');
})
afterEach(function () {
require.uncache('../wiredep');
})
before(function() {
fs.copySync('test/fixture', '.tmp');
process.chdir('.tmp');
Expand Down
2 changes: 1 addition & 1 deletion wiredep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function wiredep(opts) {
}

function mergeFileTypesWithDefaults(optsFileTypes) {
var fileTypes = $._.clone(fileTypesDefault, true);
var fileTypes = $._.cloneDeep(fileTypesDefault);

$._(optsFileTypes).each(function (fileTypeConfig, fileType) {
// fallback to the default type for all html-like extensions (php, twig, hbs, etc)
Expand Down