pool: fix pool.Connect if a server i/o hangs #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/tntp-2018-pool-connect-parallel
branch
2 times, most recently
from
0c11b09 to
ada08b4
Compare
The tests flaks sometime with the error: ``` failed to identify: read error: context deadline exceeded ``` It was decided just to increase a connect timeout.
oleg-jukovec
force-pushed
the
oleg-jukovec/tntp-2018-pool-connect-parallel
branch
from
31218d0 to
0d4f6a2
Compare
Previously, `pool.Connect` attempted to establish a connection one after another instance. It could cause the entire chain to hang if one connection hanged. Now connections are established in parallel. After the first successful connection, the remaining connections wait with a timeout of `pool.Opts.CheckTimeout`. Closes #TNTP-2018
oleg-jukovec
force-pushed
the
oleg-jukovec/tntp-2018-pool-connect-parallel
branch
from
0d4f6a2 to
6a0c2df
Compare
patapenka-alexey
approved these changes
Apr 14, 2025
palage4a
approved these changes
Apr 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
pool.Connectattempted to establish a connection one after another instance. It could cause the entire chain to hang if one connection hanged. Now connections are established in parallel. After the first successful connection, the remaining connections wait with a timeout ofpool.Opts.CheckTimeout.I didn't forget about (remove if it is not applicable):
Related issues:
Closes #TNTP-2018