test: fix flaky test #453
Merged
test: fix flaky test #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
2 times, most recently
from
0b1890e to
e7c2e9c
Compare
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
2 times, most recently
from
e002994 to
76e4a2f
Compare
bigbes
reviewed
Aug 5, 2025
bigbes
reviewed
Aug 5, 2025
bigbes
reviewed
Aug 5, 2025
bigbes
reviewed
Aug 5, 2025
bigbes
approved these changes
Aug 5, 2025
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
from
76e4a2f to
537f38f
Compare
bigbes
approved these changes
Aug 6, 2025
dmyger
reviewed
Aug 6, 2025
oleg-jukovec
requested changes
Aug 7, 2025
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
from
537f38f to
f443836
Compare
oleg-jukovec
requested changes
Aug 8, 2025
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
from
df9cc0f to
92cbe14
Compare
General context approach is used in multi-instances functions -- context is passed as a first argument.
Helper method that performs initial assigning of master/replica roles and is widely used in ConnectionPool tests was adjusted to wait for the roles to be applied successfully. Prior to this patch it doesn't, so sometimes subsequent test code might work unexpectedly (the problem was caught with TestConnectionHandlerOpenUpdateClose) Closes #452
elhimov
force-pushed
the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
from
92cbe14 to
f859fca
Compare
oleg-jukovec
approved these changes
Aug 11, 2025
dmyger
approved these changes
Aug 11, 2025
oleg-jukovec
deleted the
elhimov/gh-452-flaky-on-mac-TestConnectionHandlerOpenUpdateClose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper method that performs initial assigning of master/replica roles and is widely used in
ConnectionPooltests was adjusted to wait for the roles to be applied successfully.Prior to this patch it doesn't, so sometimes subsequent test code might work unexpectedly (the problem was caught with
TestConnectionHandlerOpenUpdateClose)Related issues:
Closes #452