buffer: allow to write zero bytes #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdzzz
force-pushed
the
buffer_empty_write
branch
3 times, most recently
from
9adadd2 to
64e8d15
Compare
mkostoevr
approved these changes
Jul 25, 2025
CuriousGeorgiy
approved these changes
Jul 26, 2025
Encoder can try to write zero bytes sometimes. For example, when it encodes an empty string. Let's simply handle this case in buffer and iterators instead of assertion. Along the way, replace the assertion in `iterator::get` method as well. It should have be done in 28bae01, but we forgot about this method because it's not used by decoder. Co-authored-by: Andrey Saranchin <[email protected]>
drewdzzz
force-pushed
the
buffer_empty_write
branch
from
64e8d15 to
399aabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoder can try to write zero bytes sometimes. For example, when it encodes an empty string. Let's simply handle this case in buffer and iterators instead of assertion.
Along the way, replace the assertion in
iterator::getmethod as well. It should have be done in 28bae01, but we forgot about this method because it's not used by decoder.Part of #93 reincarnation.