Wait methods fixes [part 1] #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousGeorgiy
force-pushed
the
wait-methods-fixes
branch
5 times, most recently
from
75e5c49 to
f18a1ba
Compare
CuriousGeorgiy
requested review from
drewdzzz and
mkostoevr
and removed request for
drewdzzz
mkostoevr
approved these changes
Aug 18, 2025
CuriousGeorgiy
force-pushed
the
wait-methods-fixes
branch
from
f18a1ba to
d07b5e3
Compare
drewdzzz
reviewed
Aug 25, 2025
|
Regarding #141 - it's good idea to do so. But for now, let's simply fix |
Let's pull out the code for checking the readiness of requested and count responses in `waitAll` and `waitCount` correspondingly. We will further use these helpers to check the futures before waiting. Needed for tarantool#133
CuriousGeorgiy
force-pushed
the
wait-methods-fixes
branch
5 times, most recently
from
10ba188 to
762d103
Compare
drewdzzz
reviewed
Sep 15, 2025
CuriousGeorgiy
force-pushed
the
wait-methods-fixes
branch
from
762d103 to
e76a1e0
Compare
Currently, `waitAll` and `waitCount` unconditionally `wait` instead of checking response readiness. If there are no more responses, it will cause them to hang indefinitely. To fix this, let's check the response readiness first. We should also move the time start to the beginning of the waiting loop, since the initial response checking overhead should not be accounted for the waiting time. Closes tarantool#133
Currently, we do not check the return code of `wait` in `waitAny`. If there is an error, we must log it and return a `nullopt`. Closes tarantool#121
CuriousGeorgiy
force-pushed
the
wait-methods-fixes
branch
from
e76a1e0 to
804c0f5
Compare
drewdzzz
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes some bugs with the Connector
wait*methods.Closes #121
closes #133