Fixes for customer and macOS build fix #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function `mempcpy` is a GNU extension and is not available on some platforms like MacOS. And, actually, `mempcpy` is the same as `memcpy`, the only difference is returned value, and it's not even used in the code that calls the function. So let's simply replace it with `memcpy`.
drewdzzz
force-pushed
the
fixes_for_customer
branch
2 times, most recently
from
6b08e02 to
b7c76d5
Compare
Such names as `LogLevel`, `Logger`, `LOG_ERROR` and so on are too common and our users can use them in their projects. It will lead to conflicts, so let's move logger to namespace `tnt` just as other utils and rename macros like `LOG_ERROR` to `TNT_LOG_ERROR`.
RedHat Enterprise Linux 7 has a bug in its toolchain - `std::string`
doesn't have `noexcept` default constructor despite standard demands it.
Unfortunately, this problem is popular and our users have filed several
reports of build failure because of this bug - constructor of `Stream`
cannot be declared as `Stream() noexcept = default;` because it contains
`std::string` fields which cannot be noexcept-default-constructible.
Let's simply replace it with `Stream() noexcept {};` construction - it
won't actually change anything anyway.
drewdzzz
force-pushed
the
fixes_for_customer
branch
from
b7c76d5 to
a88e61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details