Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus)!: remove substate value when substate is DOWN #1274

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 31, 2025

Description

fix(consensus)!: remove substate value when substate is DOWN
fix(consensus): remove lock conflict entries when transactions are/will be aborted
fix(event scanner)!: don't request unused substate and transaction data when syncing events
fix(consensus): simplify pledging and fix a couple of bugs

Motivation and Context

Greatly reduces the storage required by removing historical state.

How Has This Been Tested?

Manually, tariswap test

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Jan 31, 2025

Test Results (CI)

594 tests   - 24   594 ✅  - 24   1h 26m 22s ⏱️ - 3h 27m 44s
 55 suites  - 13     0 💤 ± 0 
  1 files    -  1     0 ❌ ± 0 

Results for commit f7af3af. ± Comparison against base commit ec0eb2e.

This pull request removes 24 tests.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:83:3
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:9:3
Scenario: Claim validator fees: tests/features/claim_fees.feature:10:3
Scenario: Concurrent calls to the Counter template: tests/features/concurrency.feature:7:3
Scenario: Confidential transfer to account that does not previously exist: tests/features/transfer.feature:151:3
Scenario: Counter template registration and invocation multiple times: tests/features/counter.feature:46:3
Scenario: Counter template registration and invocation once: tests/features/counter.feature:8:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:8:3
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:125:3
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:80:3
…

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the consensus-remove-downed-substates branch from ef0f5d9 to 4777a6e Compare January 31, 2025 10:03
@sdbondi sdbondi force-pushed the consensus-remove-downed-substates branch 2 times, most recently from e4851a8 to 2e534b7 Compare February 4, 2025 12:00
@sdbondi sdbondi force-pushed the consensus-remove-downed-substates branch from 2e534b7 to f7af3af Compare February 4, 2025 12:28
@sdbondi sdbondi merged commit ddc4632 into tari-project:development Feb 5, 2025
12 of 13 checks passed
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Feb 5, 2025
…-shard

* development:
  fix(consensus)!: remove substate value when substate is DOWN (tari-project#1274)
  feat(consensus): skip to local accept phase for aborted transactions (tari-project#1273)
  chore: update package.json for wallet client (tari-project#1272)
  chore: update package.json for wallet client (tari-project#1271)
  feat!: accumulate leader fees in substate, impl claim fees in wallet (tari-project#1270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants