Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monorepo conversion #42

Merged
merged 16 commits into from
Feb 11, 2025
Merged

feat: monorepo conversion #42

merged 16 commits into from
Feb 11, 2025

Conversation

a-h-i
Copy link
Contributor

@a-h-i a-h-i commented Feb 7, 2025

Description

In order to support both browser and nodejs environments we need to allow users to choose which packages to import.
The first step along that road is to structure the project as a monorepo of multiple packages.
At this time all the packages are required for tarijs, however in the future these requirements will be eliminated and instead passed as parameters based on which provider package is installed.

How Has This Been Tested?

Building the project

What process can a PR reviewer use to test or verify this change?

after installing proto run
moon tarijs:build then navigate to packages/tarijs directory. you should have the build output in dist subdirectory. You should also run the integration tests

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Feb 7, 2025

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Copy link
Collaborator

@mrnaveira mrnaveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of general comments:

  • Please review the .github/workflows/npm_publish.yml job file that publishes to the npm registry on new version numbers. I think for this PR a change may not be necessary but please review it and confirm that it's the case.
  • As a organization requirement we request contributors to sign commits

package.json Outdated
@@ -3,31 +3,13 @@
"version": "0.3.0",
Copy link
Collaborator

@mrnaveira mrnaveira Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently at version 0.3.1 so we need to bump this to 0.3.2 for example. Then please run npm i so the package-lock.json is also updated. Probably need to do the same for all packages individually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by switching to pnpm we no longer have a package-lock

@@ -0,0 +1,274 @@
import {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The walletconnect provider has been updated after this PR was published, so you need to apply those changes in this file to avoid a regression

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated but please review that I didn't screw up the rebase

@mrnaveira mrnaveira changed the title feat: Monorepo Conversion feat: monorepo conversion Feb 11, 2025
@a-h-i a-h-i requested a review from a team as a code owner February 11, 2025 12:28
@mrnaveira mrnaveira merged commit 4bf9cba into tari-project:main Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants