clippy

tari-project · May 24, 2024 · dc80584 · dc80584
1 parent 5e50eb8
commit dc80584
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/base_layer/common_types/src/tari_address/dual_address.rs b/base_layer/common_types/src/tari_address/dual_address.rs
@@ -127,7 +127,7 @@ impl DualAddress {
         if bytes.len() != INTERNAL_DUAL_SIZE {
             return Err(TariAddressError::InvalidSize);
         }
-        if validate_checksum(&bytes).is_err() {
+        if validate_checksum(bytes).is_err() {
             return Err(TariAddressError::InvalidChecksum);
         }
         let network = Network::try_from(bytes[0]).map_err(|_| TariAddressError::InvalidNetwork)?;

diff --git a/base_layer/common_types/src/tari_address/single_address.rs b/base_layer/common_types/src/tari_address/single_address.rs
@@ -114,7 +114,7 @@ impl SingleAddress {
         if bytes.len() != INTERNAL_SINGLE_SIZE {
             return Err(TariAddressError::InvalidSize);
         }
-        if validate_checksum(&bytes).is_err() {
+        if validate_checksum(bytes).is_err() {
             return Err(TariAddressError::InvalidChecksum);
         }
         let network = Network::try_from(bytes[0]).map_err(|_| TariAddressError::InvalidNetwork)?;

diff --git a/base_layer/core/src/test_helpers/mod.rs b/base_layer/core/src/test_helpers/mod.rs
@@ -75,7 +75,7 @@ pub fn create_orphan_block(block_height: u64, transactions: Vec<Transaction>, co
 pub async fn default_coinbase_entities(key_manager: &MemoryDbKeyManager) -> (TariKeyId, TariAddress) {
     let wallet_private_spend_key = PrivateKey::random(&mut OsRng);
     let wallet_private_view_key = PrivateKey::random(&mut OsRng);
-    let _ = key_manager.import_key(wallet_private_view_key.clone()).await.unwrap();
+    let _key = key_manager.import_key(wallet_private_view_key.clone()).await.unwrap();
     let script_key_id = key_manager.import_key(wallet_private_spend_key.clone()).await.unwrap();
     let wallet_payment_address = TariAddress::new_dual_address_with_default_features(
         PublicKey::from_secret_key(&wallet_private_view_key),

diff --git a/base_layer/wallet/src/transaction_service/mod.rs b/base_layer/wallet/src/transaction_service/mod.rs
@@ -230,7 +230,7 @@ where
         let consensus_manager = self.consensus_manager.clone();
         let factories = self.factories.clone();
         let config = self.config.clone();
-        let network = self.network.clone();
+        let network = self.network;
 
         context.spawn_when_ready(move |handles| async move {
             let outbound_message_service = handles.expect_handle::<Dht>().outbound_requester();

diff --git a/base_layer/wallet/src/utxo_scanner_service/initializer.rs b/base_layer/wallet/src/utxo_scanner_service/initializer.rs
@@ -101,7 +101,7 @@ where
             .expect("Cannot start Utxo scanner service without setting a storage backend");
         let factories = self.factories.clone();
         let node_identity = self.node_identity.clone();
-        let network = self.network.clone();
+        let network = self.network;
 
         context.spawn_when_ready(move |handles| async move {
             let transaction_service = handles.expect_handle::<TransactionServiceHandle>();

diff --git a/base_layer/wallet/tests/transaction_service_tests/service.rs b/base_layer/wallet/tests/transaction_service_tests/service.rs
@@ -253,7 +253,7 @@ async fn setup_transaction_service<P: AsRef<Path>>(
             subscription_factory,
             ts_backend,
             node_identity.clone(),
-            Network::LocalNet.into(),
+            Network::LocalNet,
             consensus_manager,
             factories,
             db.clone(),

diff --git a/integration_tests/src/merge_mining_proxy.rs b/integration_tests/src/merge_mining_proxy.rs
@@ -92,7 +92,7 @@ impl MergeMiningProxyProcess {
             .unwrap()
             .into_inner()
             .address;
-        let wallet_payment_address = TariAddress::from_bytes(&wallet_public_key).unwrap();
+        let wallet_payment_address = TariAddress::from_bytes(wallet_public_key).unwrap();
         let stealth = self.stealth;
         thread::spawn(move || {
             let cli = Cli {

diff --git a/integration_tests/src/miner.rs b/integration_tests/src/miner.rs
@@ -99,7 +99,7 @@ impl MinerProcess {
             .unwrap()
             .into_inner()
             .address;
-        let wallet_payment_address = TariAddress::from_bytes(&wallet_public_key).unwrap();
+        let wallet_payment_address = TariAddress::from_bytes(wallet_public_key).unwrap();
 
         let node = world.get_node(&self.base_node_name).unwrap().grpc_port;
         let temp_dir = world