Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update codeowners #6090

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: update codeowners #6090

merged 1 commit into from
Jan 22, 2024

Conversation

CjS77
Copy link
Collaborator

@CjS77 CjS77 commented Jan 19, 2024

Marks CI/CD files as sensitive and requiring a review by a DevOps team member.

Sensitive consensus needs a lead maintainer review.

other base layer code requires a review by core devs.

** REQUIRES "require reviews by codeowners" setting in branch protection rules **

Breaking Changes


  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Marks CI/CD files as sensitive and requiring a review by a DevOps team
member.

Sensitive consensus needs a lead maintainer review.

other base layer code requires a review by core devs.

** REQUIRES "require reviews by codeowners" setting in branch protection
rules **
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jan 19, 2024
@CjS77 CjS77 added the P-merge Process - Queued for merging label Jan 19, 2024
@CjS77
Copy link
Collaborator Author

CjS77 commented Jan 19, 2024

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-acks_required Process - Requires more ACKs or utACKs label Jan 19, 2024
Copy link

Test Results (CI)

1 264 tests   1 264 ✅  11m 31s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 259f6e0.

Copy link

Test Results (Integration tests)

 2 files  11 suites   13m 1s ⏱️
29 tests 28 ✅ 0 💤 1 ❌
30 runs  29 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 259f6e0.

@CjS77 CjS77 requested a review from stringhandler January 20, 2024 09:52
@SWvheerden SWvheerden merged commit e259702 into nextnet Jan 22, 2024
12 of 16 checks passed
@CjS77 CjS77 deleted the codeowners-nextnet branch February 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-merge Process - Queued for merging P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants