chore: minor cleanup to CipherSeed
#6322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 43m 22s ⏱️ Results for commit a4a75d9. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)33 tests 33 ✅ 13m 38s ⏱️ Results for commit a4a75d9. |
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does some housekeeping on
CipherSeedto address minor issues discovered during informal review.Motivation and Context
This provides some small updates to
CipherSeed, which is used to encrypt seed data.These updates include:
Boxto an array, since it's not secret dataHow Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Check that the changes meet the above description, particularly relating to the handling of secret data.