Fix test_util_archive.py #798
Merged
+140
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-usosyyqtqyls
branch
2 times, most recently
from
d24c1e3 to
c2b17f6
Compare
…nism Different implementations of zlib can yield different hashes. So instead, generate the archive twice and make sure the hash is the same.
ahal
force-pushed
the
ahal/push-usosyyqtqyls
branch
from
c2b17f6 to
94dd202
Compare
jcristau
reviewed
Oct 9, 2025
|
I'm not actually sure,
Yes, but there's still a test where we do do this, so I don't see a point in adding this check to the other tests as well. They're all compressing the same set of dummy files (other than |
jcristau
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.