Skip to content

Conversation

@saurL
Copy link

@saurL saurL commented Aug 27, 2025

feat(ios,macos): add event to send notification registration token

Implemented a new event on iOS and macOS to send the notification registration token.

Injected callbacks into AppDelegate to retrieve the token.

Added the notification registration call directly in the AppDelegate on macOS.

sgammon and others added 30 commits November 11, 2024 16:44
- feat(apns): add responders and events for APNS registration and
  error callbacks
- feat(apns): call `registerForRemoteNotifications` within
  `did_finish_launching`
- feat(apns): dispatch event to app for apns registration
- feat(apns): gate push notifications behind `push-notifications`
  feature

Relates-To: tauri-apps/tauri#11651
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Added focusable functionality for windows

* Fixed flag logic

* linux

* macos

* change file

* also apply on canBecomeMainWindow

* add set_focusable

* doc

* fmt

---------

Co-authored-by: Lucas Nogueira <[email protected]>
by implementing `application:willContinueUserActivityWithType:` and `application:continueUserActivity:restorationHandler:`,
reusing the existing `Event::Opened { urls }` event for the user facing api.
* Don't publish audits to crates.io

* Fix crossbeam-channel warning

* Add change file

* Use include instead of exclude

Co-authored-by: Fabian-Lars <[email protected]>

---------

Co-authored-by: Fabian-Lars <[email protected]>
- feat(apns): add responders and events for APNS registration and
  error callbacks
- feat(apns): call `registerForRemoteNotifications` within
  `did_finish_launching`
- feat(apns): dispatch event to app for apns registration
- feat(apns): gate push notifications behind `push-notifications`
  feature

Relates-To: tauri-apps/tauri#11651
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
@saurL saurL requested a review from a team as a code owner August 27, 2025 13:29
@FabianLars
Copy link
Member

The mix of verified and unverified (from different authors nonetheless) may get problematic 🤔

@FabianLars
Copy link
Member

Also can you try merging tauri-apps/tao@dev into your fork? That should clean up the diff. When i try to do it for you i get a 403 even though github says we're allowed to edit it.

@saurL
Copy link
Author

saurL commented Aug 27, 2025

I think it should be done

@saurL
Copy link
Author

saurL commented Aug 27, 2025

the non verified commit seems indeed to be problematic , not sure how to resolve it or why it is this way ( it comes from the tao repo)

@FabianLars
Copy link
Member

your commits aren't verified either but i really don't wanna drag this out any longer (in the tao repo at least) so i'll abuse my permissions for this.

@saurL
Copy link
Author

saurL commented Aug 27, 2025

Sorry for that , I hope i haven't done any commit on the tauri repo yet , I'll configure so my commit are now verified

@saurL
Copy link
Author

saurL commented Sep 5, 2025

Hello @FabianLars what's up with this PR ?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Package Changes Through 565e0e2

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.34.3 0.34.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

ah sorry i forgot to push my local changes and didn't have access to the device the last few days.

@FabianLars FabianLars changed the title Feat/push notification feat(macos): add events for push notification registration Sep 8, 2025
@FabianLars
Copy link
Member

sorry for the commit spam, can't push to the branch directly idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants