fix(ipc): skip postMessage fallback on reload when custom protocol succeeded (fix #14154) - #15881
Open
namdamdoi68-oss wants to merge 1 commit into
Conversation
…cceeded Only fall back to the postMessage interface on the first custom protocol failure. Once a custom protocol request has succeeded, a rejection during page reload is an aborted in-flight request, so falling back would run the command twice. Signed-off-by: namdamdoi68-oss <namdamdoi68@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14154
When the WebView reloads while an async command is running, the custom
protocol fetch is aborted and the code falls back to postMessage, which
re-invokes the command.
Only fall back on the first custom protocol failure. If a custom protocol
request already succeeded once, a rejection during reload is an aborted
request, so it is not retried.