fix(driver): BiDi capability stripping, send keys text field, startup readiness - #15935
Open
gronke wants to merge 3 commits into
Open
fix(driver): BiDi capability stripping, send keys text field, startup readiness#15935gronke wants to merge 3 commits into
gronke wants to merge 3 commits into
Conversation
Adapted from tauri-apps#15605 (fixes tauri-apps#15415). WebdriverIO 9+ auto-injects webSocketUrl to negotiate BiDi, which tauri-driver cannot proxy and pre-2.46 WebKitGTK rejects.
Adapted from tauri-apps#15876 (fixes tauri-apps#15871). WebKitWebDriver 2.52+ rejects Element Send Keys bodies that only carry the legacy JSON Wire Protocol value array. Co-authored-by: TheRodzz <81969589+TheRodzz@users.noreply.github.com>
Based on the unmerged upstream fix/wait-webdriver branch, with a bounded timeout and child crash detection (tauri-apps#15156).
gronke
added
the
scope: webdriver
Contributor
Package Changes Through ed37e06There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes for driving a Tauri app through tauri-driver on Linux with modern WebDriver clients.
webSocketUrlcapability fromalwaysMatchand everyfirstMatchentry before forwarding (adapted from fix(driver): strip BiDi webSocketUrl capability before forwarding (fix #15415) #15605).textfield on Element Send Keys when only the legacyvalueis present, required by WebKitWebDriver 2.52+ (adapted from fix(driver): preserve W3C text field on element send keys #15876).fix/wait-webdriverbranch).Verified locally against WebKitWebDriver 2.52.3: forwarded session bodies have
webSocketUrlremoved, legacy send-keys bodies gaintext,/statusproxies as soon as the port opens, and a crashing native driver exits tauri-driver with an error.Closes #15934