Arc/Mutex refactors - #15952
Conversation
Package Changes Through fae76b3There are 14 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap()); | ||
| let out_dir = PathBuf::from(env::var_os("OUT_DIR").unwrap()); | ||
|
|
||
| let checked_features_out_path = out_dir.join("checked_features"); |
There was a problem hiding this comment.
Maybe we can add a bit of context here that we're at it, this is used for the unit test in tauri to check we're not checking non-existing features with has_feature
There was a problem hiding this comment.
I didn't get what that code was doing anyway? It looks like the code is anticipating multiple features here, which is where the fn has_feature function would make sense, but it's only called a single time with has_feature("custom-protocol").
There was a problem hiding this comment.
I didn't get what that code was doing anyway?
this is used for the unit test in tauri to check we're not checking non-existing features with
has_feature
I think we might still want to keep this function in case we do something with it in the future
| #[inline(always)] | ||
| pub fn state(&self) -> Arc<StateManager> { | ||
| self.state.clone() | ||
| self.webview.manager.state.clone() | ||
| } | ||
|
|
||
| /// A reference to the state manager associated with application. | ||
| #[inline(always)] | ||
| pub fn state_ref(&self) -> &StateManager { | ||
| &self.state | ||
| &self.webview.manager.state | ||
| } |
There was a problem hiding this comment.
Candidates to make private in v3, think they are pub by accident.
There was a problem hiding this comment.
Agreed, we could put in a todo comment + a deprecation warning, people should use https://docs.rs/tauri/latest/tauri/trait.Manager.html#method.state instead
2 participants
Some low-hanging refactors, removes one
Mutexand oneArc.