Skip to content

Editorial: Use named time constants - #3929

Merged
ljharb merged 1 commit into
tc39:mainfrom
ptomato:use-time-constants
Aug 6, 2026
Merged

Editorial: Use named time constants#3929
ljharb merged 1 commit into
tc39:mainfrom
ptomato:use-time-constants

Conversation

@ptomato

@ptomato ptomato commented Jul 24, 2026

Copy link
Copy Markdown
Member

Use the existing msPerDay, MinutesPerHour, SecondsPerMinute in more places where applicable.

Add new constants nsPerSecond, nsPerMillisecond, and nsPerMicrosecond, and use those as well.

@ptomato ptomato mentioned this pull request Jul 24, 2026

@gibson042 gibson042 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an ESMeta issue for understanding the new terms.

Comment thread spec.html Outdated
Comment thread spec.html
@ptomato

ptomato commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Please open an ESMeta issue for understanding the new terms.

es-meta/esmeta#349

@gibson042 gibson042 added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 29, 2026
Use the existing msPerDay, MinutesPerHour, SecondsPerMinute in more places where applicable.

Add new constants nsPerSecond, nsPerMillisecond, and nsPerMicrosecond, and use those as well.
@ljharb
ljharb force-pushed the use-time-constants branch from a948e3a to 777fc02 Compare August 6, 2026 08:32
@ljharb ljharb added the request preview ask the bot to trigger a PR preview label Aug 6, 2026
@github-actions github-actions Bot removed the request preview ask the bot to trigger a PR preview label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3929 and as multiple pages at https://tc39.es/ecma262/pr/3929/multipage .

@ljharb
ljharb merged commit 777fc02 into tc39:main Aug 6, 2026
12 checks passed
@ptomato
ptomato deleted the use-time-constants branch August 6, 2026 15:08
Jack-Works added a commit to engine262/engine262 that referenced this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants