Skip to content

Editorial: Update GetOption to throw a TypeError when a required option is missing #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gibson042 merged 3 commits into from
Jun 11, 2026
Merged

Editorial: Update GetOption to throw a TypeError when a required option is missing #1068

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d0d75f
Editorial: Update GetOption to throw a TypeError when a required opti…
gibson042 May 18, 2026
202c1db
Editorial: Mark DisplayNames "type" as required in its call to GetOption
gibson042 May 18, 2026
f9b49f8
fixup! Editorial: Mark DisplayNames "type" as required in its call to…
gibson042 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/displaynames.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h1>Intl.DisplayNames ( _locales_, _options_ )</h1>
1. Let _r_ be _optionsResolution_.[[ResolvedLocale]].
1. Let _style_ be ? GetOption(_options_, *"style"*, ~string~, « *"narrow"*, *"short"*, *"long"* », *"long"*).
1. Set _displayNames_.[[Style]] to _style_.
1. Let _type_ be ? GetOption(_options_, *"type"*, ~string~, « *"language"*, *"region"*, *"script"*, *"currency"*, *"calendar"*, *"dateTimeField"* », *undefined*).
1. Let _type_ be ? GetOption(_options_, *"type"*, ~string~, « *"language"*, *"region"*, *"script"*, *"currency"*, *"calendar"*, *"dateTimeField"* », ~required~).
1. If _type_ is *undefined*, throw a *TypeError* exception.
Comment thread
gibson042 marked this conversation as resolved.
Outdated
1. Set _displayNames_.[[Type]] to _type_.
1. Let _fallback_ be ? GetOption(_options_, *"fallback"*, ~string~, « *"code"*, *"none"* », *"code"*).
Expand Down
2 changes: 1 addition & 1 deletion spec/negotiation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ <h1>
<emu-alg>
1. Let _value_ be ? Get(_options_, _property_).
1. If _value_ is *undefined*, then
1. If _default_ is ~required~, throw a *RangeError* exception.
1. If _default_ is ~required~, throw a *TypeError* exception.
1. Return _default_.
1. If _type_ is ~boolean~, then
1. Set _value_ to ToBoolean(_value_).
Expand Down
Loading