Editorial: Make the Locale object abstract operation algorithms more explicit#1087
Open
gibson042 wants to merge 1 commit into
Open
Editorial: Make the Locale object abstract operation algorithms more explicit#1087gibson042 wants to merge 1 commit into
gibson042 wants to merge 1 commit into
Conversation
ptomato
approved these changes
Jul 7, 2026
ptomato
left a comment
ptomato
left a comment
Contributor
There was a problem hiding this comment.
This is an improvement IMO.
| 1. Assert: The first subtag of _baseName_ can be matched by the <code>unicode_language_subtag</code> Unicode locale nonterminal. | ||
| 1. Return the first subtag of _baseName_. | ||
| 1. Let _subtags_ be StringSplitToList(_baseName_, *"-"*). | ||
| 1. Assert: _subtags_[0] is matched by the <code>unicode_language_subtag</code> Unicode locale nonterminal. |
Contributor
There was a problem hiding this comment.
Note, "subtags has at least one element" is implicit here and in similar language below, but I think that's OK.
Member
Author
There was a problem hiding this comment.
That's actually guaranteed by the final three steps of StringSplitToList.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1083