Editorial: Remove iffy usage of undefined rounding mode - #1092
Merged
gibson042 merged 1 commit intoJul 29, 2026
Conversation
ToRawFixed, ToRawPrecision, and ApplyUnsignedRoundingMode all accepted undefined as their rounding mode parameter, only to hit an assertion if undefined was passed while any rounding actually needed to happen. It turns out this was to support one usage of ToRawFixed with hardcoded rounding parameters. Remove this usage of ToRawFixed; with the given hardcoded parameters, its implementation collapses to one line. Ref: tc39/ecma262#3759 (comment)
gibson042
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToRawFixed, ToRawPrecision, and ApplyUnsignedRoundingMode all accepted undefined as their rounding mode parameter, only to hit an assertion if undefined was passed while any rounding actually needed to happen.
It turns out this was to support one usage of ToRawFixed with hardcoded rounding parameters.
Remove this usage of ToRawFixed; with the given hardcoded parameters, its implementation collapses to one line.
Ref: tc39/ecma262#3759 (comment)