Editorial and docs updates #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptomato
commented
Jan 14, 2025
ptomato
commented
- Use "RFC 9557 string" where appropriate
- Use "available time zone identifier" where appropriate
- Update test262
For some reason, this identifier is listed both in TZDB's backward and backzone files. The correct one to use is backzone. Firefox is currently the only implementation that gets this correct. Correct the divergence in the polyfill.
Two incorrect tests from the SpiderMonkey staging tests were fixed, but one more was added.
The intention here was to set a default, not override any existing value. Thanks to Anba for spotting this. Closes: #3064
It is stage 4 now! Closes: #3067
Instead of always using a fake English-only format in this example, rely on Intl.DurationFormat if it is present. Still fall back to the fake format if it is not. See: #3067
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
+ Coverage 96.21% 96.37% +0.15%
==========================================
Files 21 21
Lines 9867 9872 +5
Branches 1796 1800 +4
==========================================
+ Hits 9494 9514 +20
+ Misses 323 311 -12
+ Partials 50 47 -3 ☔ View full report in Codecov by Sentry. |
justingrant
reviewed
Jan 14, 2025
justingrant
reviewed
Jan 14, 2025
justingrant
reviewed
Jan 14, 2025
justingrant
reviewed
Jan 14, 2025
justingrant
reviewed
Jan 14, 2025
justingrant
reviewed
Jan 14, 2025
Ms2ger
approved these changes
Jan 14, 2025
Mostly in docs, but also in error messages, comments, etc., and in some cases in the prose parts of the spec text. In some cases phrased to keep in mind that ISO 8601 probably has better name recognition for the time being. Closes: #3071
It does, in fact, include one, and that's where the HTML format comes from.
In a few places, we used "time zone identifier" (any string consisting of allowed code units) where "available time zone identifier" would be correct. Use that instead. See: #3055
Addresses GHSA-3xgq-45jj-v275 Although cross-spawn is a dependency of eslint and this probably doesn't matter, this silences a warning.
We don't want to imply that Z is the only way to get an exact time.
|
Comments addressed. I appreciate all the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.