Add 'framework' for decoding tests with a sample scope test #34
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't add reviewers for some reason, so pinging @takikawa and @jridgewell directly. |
jridgewell
approved these changes
Aug 28, 2025
| @@ -0,0 +1 @@ | |||
| {"file":"single-root-original-scope.js","mappings":[],"sources":[{"url":"original_0.js","content":null,"ignored":false,"scope":{"start":{"line":0,"column":0},"end":{"line":10,"column":0},"name":null,"kind":"global","isStackFrame":false,"variables":[],"children":[]}}],"ranges":[{"start":{"line":0,"column":0},"end":{"line":0,"column":10},"definitionIndex":0,"stackFrameType":"none","callSite":null,"bindings":[],"children":[]}]} | |||
There was a problem hiding this comment.
Pretty-printing this would make is easier for humans to review what is going on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in the TC39-TG4 meeting of 2025-08-13. tl;dr, we'd like to have a set of decoding tests that store a source map and a serialized version of the "Decoded Source Map Record" next to each other.
The PR currently keeps the "decoding test source maps" separate from the other source map fixtures in "resources/". If we also want to store .golden for the source maps in "resources/", I can shuffle it around.
The PR adds a .d.ts file for the golden format, as we can't map the "Decoded Source Map Record" 1:1 due to the cycles in the object hierarchy.
Once we have ironed out the details on this PR, I'll start with a follow-up PR for "scopes" spec tests.