Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ODF DOM element cloning #314

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fixing ODF DOM element cloning #314

merged 1 commit into from
Jul 30, 2024

Conversation

svanteschubert
Copy link
Contributor

Fixes #313 - OdfElement cloneNode omitted wrongly some ODF attribute for cloning

@svanteschubert svanteschubert requested a review from mistmist July 29, 2024 19:59
@svanteschubert svanteschubert self-assigned this Jul 29, 2024
@svanteschubert svanteschubert linked an issue Jul 29, 2024 that may be closed by this pull request
Create a full copy of a spreadsheet in an ODF Spreadsheet document using the ODF Toolkit. #313
Closed
@svanteschubert
Copy link
Contributor Author

svanteschubert commented Jul 29, 2024 •
edited
Loading

PS: How the problem/solution became apparent:
I have opened the content.xml of the output document and compared the two tables (original and cloned) and realized that the @office:value-type="float" was missing in the cloned table.
Therefore in the various office applications the default type string was applied and the content was left aligned (as all strings) contrary to the numbers on the right side.

@mistmist mistmist merged commit 02e6bbf into master Jul 30, 2024
3 checks passed
@mistmist mistmist deleted the cloning branch July 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistmist mistmist mistmist approved these changes

Assignees

@svanteschubert svanteschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a full copy of a spreadsheet in an ODF Spreadsheet document using the ODF Toolkit.
2 participants
@svanteschubert @mistmist