Skip to content

zeroProj fix & small optimization #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

zeroProj fix & small optimization #7

wants to merge 2 commits into from

Conversation

Arvolear
Copy link

@Arvolear Arvolear commented Nov 4, 2024 •
edited
Loading

  1. As I see here, zeroProj function has to return the (0, 0, 1) point instead of (0, 1, 0).
  2. Noticed that P[2] in the toProjectivePoint() function is always equal to 1, so several function calls and checks may be safely removed.

@Arvolear Arvolear changed the title Small optimization zeroProj fix & small optimization Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arvolear