Skip to content

πŸ”€ :: ν•™μƒνšŒμ—μ„œ μ™ΈμΆœ μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λŠ” κΈ°λŠ₯ κ΅¬ν˜„ #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KimGyeongsuuu wants to merge 13 commits into
base: main
Choose a base branch
from
Open

πŸ”€ :: ν•™μƒνšŒμ—μ„œ μ™ΈμΆœ μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λŠ” κΈ°λŠ₯ κ΅¬ν˜„ #8

KimGyeongsuuu wants to merge 13 commits into from

Conversation

@KimGyeongsuuu
Copy link
Contributor

@KimGyeongsuuu KimGyeongsuuu commented Jun 16, 2023

πŸ’‘ κ°œμš”

ν•™μƒνšŒμ—μ„œ μ™ΈμΆœ μƒνƒœλ₯Ό 관리

πŸ“ƒ μž‘μ—…μ‚¬ν•­

  1. ν•™μƒνšŒμ—μ„œ μ™ΈμΆœ μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λŠ” κΈ°λŠ₯ κ΅¬ν˜„
  2. enum으둜 μ™ΈμΆœ μƒνƒœλ₯Ό κ΅¬λΆ„ν•΄μ„œ μƒνƒœμ— λ”°λΌμ„œ λ””μŠ€μ½”λ“œ μ „μ†‘ν•˜κΈ° κ΅¬ν˜„

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ‚΄μš©

@KimGyeongsuuu
✨ μ˜μ‘΄μ„± μΆ”κ°€
65a3c33
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœ redis μ—”ν‹°ν‹°
f6a8549
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœ enum
3559f95
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœκ΄€λ¦¬ usecase
4d5964f
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœκ΄€λ¦¬ dto
a7eefac
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœκ΄€λ¦¬ dto converter
7444e20
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœκ΄€λ¦¬ api
46ebf71
@KimGyeongsuuu
✨ :: μ™ΈμΆœμƒνƒœκ΄€λ¦¬ redis μ €μž₯μ‹œκ°„ 등둝 , λ ˆν¬μ§€ν† λ¦¬ 생성
cf379b6
@KimGyeongsuuu
♻️ :: 클래슀λͺ… μˆ˜μ •
736be46
@KimGyeongsuuu
✨ 곡휴일 μ˜ˆμ™Έμ²˜λ¦¬
b04e145
@KimGyeongsuuu
✨ enum으둜 μ™ΈμΆœ μƒνƒœ κ΅¬λΆ„ν•˜κ³  λ””μŠ€μ½”λ“œ 전솑 usecase
6e4abd0
@KimGyeongsuuu KimGyeongsuuu changed the title Feature/6 outing status πŸ”€ ::Feature/6 outing status Jun 16, 2023
@KimGyeongsuuu KimGyeongsuuu changed the title πŸ”€ ::Feature/6 outing status πŸ”€ :: ν•™μƒνšŒμ—μ„œ μ™ΈμΆœ μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λŠ” κΈ°λŠ₯ κ΅¬ν˜„ Jun 16, 2023
SungGil-5125
SungGil-5125 reviewed Jun 16, 2023
View reviewed changes
src/main/kotlin/com/project/goms/domain/studentCouncil/usecase/OutingBanUseCase.kt Outdated
outingStatusUUID = UUID.randomUUID(),
expiredAt = outingStatusExpTimeProperties.expiredAt
)
log.info { "이번주 μ™ΈμΆœ λΆˆκ°€λŠ₯ γ……γ„±" }
Copy link
Contributor

@SungGil-5125 SungGil-5125 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

둜그 μž‘μ—…μ„ μ΄λ ‡κ²Œ ν•˜μ‹œλ©΄...γ…‹γ…‹γ…‹
goms log듀은 μ€‘κ΄„ν˜Έκ°€ μ•„λ‹ˆλΌ μ†Œκ΄„ν˜Έλ‘œ ν–ˆμ—ˆλŠ”λ°, 이것도 μ»¨λ²€μ…˜μ„ 지킀면 쒋을거 κ°™μ•„μš”.

Suggested change
log.info { "이번주 μ™ΈμΆœ λΆˆκ°€λŠ₯ γ……γ„±" }
log.info("μ΄λ²ˆμ£ΌλŠ” μ™ΈμΆœ λΆˆκ°€λŠ₯ μƒνƒœ μž…λ‹ˆλ‹€." )

src/main/kotlin/com/project/goms/infrastructure/discord/usecase/SendDiscordUseCase.kt
content += "> 였늘 μ™ΈμΆœν•˜λ‹€ κ±Έλ¦΄μ‹œ 무단 μ™ΈμΆœμž…λ‹ˆλ‹€. \n"
}

OutingStatus.PUBLIC_HOLIDAY -> {
Copy link
Contributor

@SungGil-5125 SungGil-5125 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μœ„μ— 처리 방식을 보면 λ‹€ OUTING_AVAILABLE, OUTING_UNAVAILABLE μΌλ•Œλ§Œ 처리 ν–ˆλŠ”λ° 곡휴일(PUBLIC_HOLIDAY)μΌλ•ŒλŠ” μ–΄λ–»κ²Œ κ΅¬λΆ„ν•˜κ³  처리 ν• κΉŒμš”?

src/main/kotlin/com/project/goms/infrastructure/discord/usecase/SendDiscordUseCase.kt
override fun sendMessage() {
var content = ""
var outingStatus: OutingStatus = OutingStatus.OUTING_AVAILABLE
val lateOneWeekAgoCount = lateRepository.lateCountOntWeekAgo(LocalDate.now().minusWeeks(1))
Copy link
Contributor

@SungGil-5125 SungGil-5125 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ œκ°€ μ˜ˆμ „μ— μž‘μ„±ν•œ μ½”λ“œλ₯Ό λ³΄λ©΄μ„œ λŠλ‚€κ±΄λ° 7μ‹œ 40뢄에 지각생을 μ €μž₯ν•˜λŠ” μŠ€μΌ€μ₯΄λŸ¬μ—μ„œ 3λͺ… 이상, 미만 μΌλ•Œ 각각 OutingStatus(Redis)에 OutingStatus(enum)을 μ €μž₯ν•˜λ©΄ μ €λ ‡κ²Œ 쿼리문(μ €λ²ˆμ£Όμ— μ™ΈμΆœμžκ°€ 3λͺ… 이상 검증)을 날릴 ν•„μš”κ°€ μ—†κ³ 
μ•„λž˜ 둜직과 같이 if문을 μ¨μ„œ 처리 ν•  ν•„μš”κ°€ μ—†μ–΄ 보이고, λ””μŠ€ν¬ 보닀 λ©”λͺ¨λ¦¬μ—μ„œ κ°€μ Έμ˜€λŠ”κ²Œ 더 λΉ λ₯΄λ‹ˆ μ„±λŠ₯도 올라갈거라고 μƒκ°ν•˜λŠ”λ° 이에 λŒ€ν•΄μ„  μ–΄λ–»κ²Œ μƒκ°ν•˜μ‹€κΉŒμš”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SungGil-5125 SungGil-5125 SungGil-5125 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KimGyeongsuuu @SungGil-5125