-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for rbac v1 API endpoint #6
Conversation
kubernetes >=1.8 moved rbac to v1
Thank you for the contribution! Looks good @n0n0x . We are currently still setting up e2e testing so I will need to test it out manually on 1.8 and will merge as soon as I can. |
Thanks so much, we are looking to move the direction. Be sure to check the updates for router. |
Assuming this passes testing, it should ideally get merged simultaneously with four other components that also have RBAC roles and bindings. As long as it all goes into the same release I looked at E2E testing this weekend and did not get it done, but I think I will be trying this against GKE and Minikube first. I don't know if Minikube alone can support the E2E tests on my machines. (The specs for the test cluster are larger than any machines I have currently at my disposal, but I have a number of free GKE credits, so I should be able to run the suite a few times at no cost.) I'm going to try to execute the E2E tests without the whole cluster leasing thing at first, as I can't afford to keep multiple test clusters running continuously throughout the day when they are not being used... I'm hoping it does not take more than about two hours for the full suite to run with an appropriately sized cluster and I can get a bead on the cost to test a PR against a single cloud type. Running the E2E suite for the first time will probably go smoother (or get done faster) if someone else who has already run the suite before is available for a pep-talk. |
Awesome, I'll get into adapting the other components that use RBAC, @kingdonb besides controller and router which are the other two components? |
Done, Did a quick search on the organization and found all the other components, here is a list of PRs: controller: #6 Let me know if any other component is missing! |
That is the same list of 5 that I came up with when I grepped. Thank you @n0n0x ! |
That's interesting... teamhephy/builder#1 CI failed |
Yep, according to travi's job log, it is unrelated to my PR. The Here's a link to the previous I can maybe copy it and open a new PR and see if it works, but It might fetch things from deis repo |
I made a new PR (teamhephy/builder#2) where CI passes, but I am skeptic of the actual results 😝 |
chore(Certificate):change cluster-issuer location
As of kubernetes 1.8 RBAC is now stable and the endpoint has changed to rbac.authorization.k8s.io/v1 . I have kept compatibility for older k8s versions.
This is my first PR, let me know if something is missing!
List of PRs related to this:
controller: #6
router: teamhephy/router#5
monitor: teamhephy/monitor#1
fluentd: teamhephy/fluentd#2
builder: teamhephy/builder#1