Repository navigation
[TIDAL] Fix Rollup build by setting explicit TypeScript include globs - #384
Merged
Merged
Conversation
rollup-plugin-typescript2's default include extglob ("**/*.ts+(|x)") no
longer matches any file under picomatch >=2.3.2 (pulled in via #380), so
the plugin skipped every .ts file and `yarn build` failed with
"Unexpected token". Setting plain `**/*.ts`/`**/*.tsx` globs restores a
working build.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lorgan3
force-pushed
the
fix-rollup-typescript-include
branch
from
June 15, 2026 13:06
2199a66 to
4070ca7
Compare
lorgan3
marked this pull request as ready for review
June 15, 2026 13:27
lorgan3
requested review from
BeirlaenAaron,
KristofColpaert,
eniskraasniqi1,
farazatarodi,
jelledc,
lowiebenoot and
qubis741
and removed request for
a team
June 15, 2026 13:27
jelledc
approved these changes
Jun 15, 2026
farazatarodi
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
yarn buildhas been failing withError: Unexpected token (Note that you need plugins to import files that are not JavaScript)on every Node version (16/20/24).Root cause:
rollup-plugin-typescript2@0.32.1relies on a defaultincludeextglob (["*.ts+(|x)", "**/*.ts+(|x)"]). The recentpicomatchbump to 2.3.2 (pulled in via #380) no longer matches that empty-alternation extglob, so the plugin's filter skipped every.tsfile, the TypeScript was never compiled, and Rollup tried to parse raw TS.Fix: set explicit, plain
include: ['**/*.ts', '**/*.tsx']globs on the plugin, sidestepping the broken default. Verifiedyarn buildnow produces all three bundles (cjs/es/umd) on Node 24.Manual check
Checklist for a thorough manual check