refactor(ingest): replace CORS_ORIGINS config with origin reflecting#5
Merged
johannmachemer merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
…reflecting Auth is enforced via API keys and JWTs, not origin restrictions, so a configurable CORS allowlist adds complexity without security benefit. The ingest API now reflects all origins with credentials support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORS_ORIGINSenv var and configurable allowlist from the ingest APIorigin: true+credentials: true(reflects all origins)Changes
corsOriginsfrom config, types, app options, and CORS pluginaccess-control-allow-credentialsassertionCORS_ORIGINSfrom.env.example,docker-compose.yml,turbo.json, self-hosting docs, error catalog, and SDK specsTest plan
credentials: trueassertionCORS_ORIGINSenv varOriginheader receive correct reflected CORS headers