Skip to content

Task #000000 chore : Bulk Course Assignment Failing Due to Database connection Limit #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamnileshmittha wants to merge 2 commits into
base: dev-joomla4
Choose a base branch
from
Open

Task #000000 chore : Bulk Course Assignment Failing Due to Database connection Limit #166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ab01a
Task #000000 chore : Bulk Course Assignment Failing Due to Database C…
iamnileshmittha Dec 31, 2025
fbe5874
Task #000000 chore : Bulk Course Assignment Failing Due to Database C…
iamnileshmittha Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/com_tjcertificate/administrator/controllers/bulktrainingrecord.json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ public function save($key = null, $urlVar = null)
$data['is_external'] = 1;

unset($data['assigned_user_id']);

$queueProducer = new TJQueueProduce;

Comment thread
coderabbitai[bot] marked this conversation as resolved.
foreach ($userIds as $userId)
{
if (ComponentHelper::isEnabled($this->comMultiAgency) && $params->get('enable_multiagency'))
Expand Down Expand Up @@ -132,7 +133,7 @@ public function save($key = null, $urlVar = null)
if (ComponentHelper::isEnabled('com_tjqueue') && $params->get('tjqueue_records'))
{
$recordsModel = TJCERT::model('BulkTrainingRecord', array('ignore_request' => true));
$response = $recordsModel->addToQueue($data);
$response = $recordsModel->addToQueue($data, $queueProducer);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
$msg = $response ? Text::_("COM_TJCERTIFICATE_RECORDS_ADDED_TO_QUEUE_SUCCESSFULLY") : Text::_("COM_TJCERTIFICATE_RECORDS_FAILED");
$returnData['msg'] = $msg;
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ public function validate($form, $data, $group = null)
*
* @since __DEPLOY_VERSION__
*/
public function addToQueue($data)
public function addToQueue($data, $queueProducer = null)
{
$return = array();
$messageBody = (object) $data;
$TJQueueProduce = $queueProducer ?: new TJQueueProduce;
Comment on lines +110 to +114
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

find . -name "bulktrainingrecord.php" -type f

Repository: techjoomla/com_tjcertificate

Length of output: 304

🏁 Script executed:

head -200 src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php | tail -100

Repository: techjoomla/com_tjcertificate

Length of output: 2515

🏁 Script executed:

find . -name "*TJQueueProduce*" -o -name "*tjqueue*" -type f | head -20

Repository: techjoomla/com_tjcertificate

Length of output: 301

🏁 Script executed:

rg "class TJQueueProduce" -A 20

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

rg "TJQueueProduce" -l

Repository: techjoomla/com_tjcertificate

Length of output: 235

🏁 Script executed:

rg "class TJQueue" -A 10

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

# Check variable naming conventions in the model files
rg "\$[A-Z][a-zA-Z]*\s*=" src/components/com_tjcertificate/administrator/models/ | head -20

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

# Check if type hints are used in other methods in this file
grep -n "function.*\?" src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php | head -10

Repository: techjoomla/com_tjcertificate

Length of output: 305

🏁 Script executed:

# Check Joomla standards - look at other PHP files in the component for naming patterns
rg "public function.*\$[a-z][a-z]*\s*=" src/components/com_tjcertificate/administrator/ -A 3 | head -30

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

# Find where TJQueueProduce is instantiated or imported
rg "new TJQueueProduce" -B 5 -A 2

Repository: techjoomla/com_tjcertificate

Length of output: 1811

🏁 Script executed:

# Search for use statements or includes that might define TJQueueProduce
rg "use.*TJQueue|require.*TJQueue|include.*TJQueue"

Repository: techjoomla/com_tjcertificate

Length of output: 182

🏁 Script executed:

# Check the controller file to see if TJQueueProduce is used there
cat src/components/com_tjcertificate/administrator/controllers/bulktrainingrecord.json.php | grep -A 10 -B 10 "TJQueue"

Repository: techjoomla/com_tjcertificate

Length of output: 736

🏁 Script executed:

# Check Joomla coding standards - look for other variable declarations with PascalCase or camelCase in models
rg "\\\$[a-z][a-zA-Z]*\s*=" src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php | head -15

Repository: techjoomla/com_tjcertificate

Length of output: 634

🏁 Script executed:

# Check if TJQueueProduce might be in a lib or common folder
find . -path ./node_modules -prune -o -name "*.php" -type f -exec grep -l "class.*TJQueue" {} \;

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

# Check the beginning of bulktrainingrecord.php to see all imports and class declaration
head -50 src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php

Repository: techjoomla/com_tjcertificate

Length of output: 1350

🏁 Script executed:

# Look at variable naming patterns throughout the entire bulktrainingrecord.php file
rg "\\\$[A-Z][a-zA-Z]+" src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php

Repository: techjoomla/com_tjcertificate

Length of output: 300

🏁 Script executed:

# Check other model files to see variable naming conventions used in this component
rg "\\\$[A-Z][a-zA-Z]+\s*=" src/components/com_tjcertificate/administrator/models/ | head -20

Repository: techjoomla/com_tjcertificate

Length of output: 206

🏁 Script executed:

# Check Joomla official coding standards reference
# Look at other files in the component for mixed case variable patterns
rg "\\\$[A-Z][a-z]+[A-Z]" src/components/com_tjcertificate/ | head -20

Repository: techjoomla/com_tjcertificate

Length of output: 459

🏁 Script executed:

# Verify that the method is being called correctly in the controller
cat src/components/com_tjcertificate/administrator/controllers/bulktrainingrecord.json.php | grep -A 5 "\$queueProducer"

Repository: techjoomla/com_tjcertificate

Length of output: 538

🏁 Script executed:

# Check if type hints are used in the constructor or other methods
grep -n "public function\|private function\|protected function" src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php -A 2

Repository: techjoomla/com_tjcertificate

Length of output: 482

🏁 Script executed:

# Look for any use of type hints (? for nullable types) in the codebase
rg "\?\w+\s+\$" src/components/com_tjcertificate/administrator/ | head -10

Repository: techjoomla/com_tjcertificate

Length of output: 766

🏁 Script executed:

# Check if this naming pattern matches the class name pattern in the codebase
rg "class.*TJQueue|class.*TjCertificate" src/components/com_tjcertificate/

Repository: techjoomla/com_tjcertificate

Length of output: 5012

🏁 Script executed:

# Search for the TJQueueProduce class definition to understand connection handling
find . -name "*.php" -type f -exec grep -l "class TJQueueProduce" {} \;

Repository: techjoomla/com_tjcertificate

Length of output: 54

🏁 Script executed:

# Check if there are any other instances of PascalCase variable names matching class names
rg "\\\$[A-Z][a-zA-Z]+\s*=" src/components/com_tjcertificate/ -B 1 | head -30

Repository: techjoomla/com_tjcertificate

Length of output: 522

🏁 Script executed:

# Look at the actual controller usage context to see how reuse works
cat src/components/com_tjcertificate/administrator/controllers/bulktrainingrecord.json.php | grep -B 10 -A 15 "foreach.*userIds"

Repository: techjoomla/com_tjcertificate

Length of output: 1033

🏁 Script executed:

# Check Joomla PSR-12 standards - examine imports and naming conventions
head -30 src/components/com_tjcertificate/administrator/models/bulktrainingrecord.php

Repository: techjoomla/com_tjcertificate

Length of output: 890

Consider using camelCase for variable naming and adding type hints per Joomla standards.

The dependency injection approach correctly enables instance reuse across multiple calls. In the controller, a single TJQueueProduce instance is created once and passed to this method via the $queueProducer parameter, reducing producer instantiation.

However:

  1. Variable naming: $TJQueueProduce uses PascalCase, which violates PHP/Joomla coding standards. Variable names should use camelCase (e.g., $tjQueueProduce or consistently use the parameter name $queueProducer instead).

  2. Type hint: Add a type hint to the parameter for consistency with modern Joomla standards:

    public function addToQueue($data, ?TJQueueProduce $queueProducer = null)


try
{
$TJQueueProduce = new TJQueueProduce;

// Set message body
$TJQueueProduce->message->setBody(json_encode($messageBody));
Expand Down