Skip to content

Issue #15 fix: User update (patch) is not working for resource app=users&resource=user : without forcecreate #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaivk369 wants to merge 7 commits into
base: release-2.0.1
Choose a base branch
from
Open

Issue #15 fix: User update (patch) is not working for resource app=users&resource=user : without forcecreate #17

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7eec8ad
support for x-identifier pushed
Jan 30, 2018
78bf09b
Merge branch 'release-2.0.1' of github.com:techjoomla/plg_api_users i…
May 9, 2019
3a8c9fc
Issue #15 fix: User update (patch) is not working for resource #16
May 9, 2019
b088c84
Issue #15 fix: removed folders from fork
May 9, 2019
d5b736f
Issue #15 santinize method modified to take user param by reference
May 10, 2019
1f16a95
Changes in Delete method
May 10, 2019
5e6ef1a
The type for x-identifier changed to CMD
May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/language/en-GB/en-GB.plg_api_users.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PLG_API_USERS="API - Users"
PLG_API_USERS_DESCRIPTION="This plugin exposes users to the Joomla! API. Supports creation, listing and login for users."
PLG_API_USERS_BAD_REQUEST_MESSAGE="Bad request"
PLG_API_USERS_REQUIRED_DATA_EMPTY_MESSAGE="Required data is empty"
PLG_API_USERS_ACCOUNT_CREATED_SUCCESSFULLY_MESSAGE="Congratulations! Your account has been created successfully"
PLG_API_USERS_ACCOUNT_CREATED_SUCCESSFULLY_MESSAGE="Congratulations! Account has been created successfully"
PLG_API_USERS_PROFILE_CREATED_SUCCESSFULLY_MESSAGE="profile created successfully"
PLG_API_USERS_UNABLE_CREATE_PROFILE_MESSAGE="Unable to create profile"
PLG_API_USERS_EASYSOCIAL_NOT_INSTALL_MESSAGE="Easysocial is not installed properly"
Expand All @@ -15,3 +15,7 @@ PLG_API_USERS_UNSUPPORTED_METHOD_POST="unsupported method,please use get method"
PLG_API_USERS_USERS="users/"
PLG_API_USERS_IN_DELETE="in delete"
PLG_API_USERS_IN_POST="in post"

; Since v2.0.1
PLG_API_USERS_ACCOUNT_UPDATED_SUCCESSFULLY_MESSAGE="Account details updated successfully"
PLG_API_USERS_USER_DELETE_MESSAGE="Account deleted successfully"
204 changes: 110 additions & 94 deletions src/users/user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
*/
class UsersApiResourceUser extends ApiResource
{
/**
* Array of fields to be unset
*
* @var array
* @since 2.0.1
*/
private $fieldsToSanitize = array('password', 'password_clear', 'otpKey', 'otep');

/**
* Function to create and edit user record.
*
Expand All @@ -28,77 +36,43 @@ class UsersApiResourceUser extends ApiResource
*/
public function post()
{
$app = JFactory::getApplication();
$userIdentifier = $app->input->get('id', 0, 'String');
$formData = $app->input->getArray();
$params = JComponentHelper::getParams("com_users");
$response = new stdClass;

$xidentifier = $app->input->server->get('HTTP_X_IDENTIFIER');
$fidentifier = $app->input->server->get('HTTP_FORCECREATE');
$app = JFactory::getApplication();
$params = JComponentHelper::getParams("com_users");
$formData = $app->input->getArray();
$userIdentifier = $app->input->get('id', 0, 'string');

if ($formData['username'] == '' || $formData['name'] == '' || $formData['email'] == '')
if (isset($formData['fields']))
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_REQUIRED_DATA_EMPTY_MESSAGE'));

return;
$formData['com_fields'] = $formData['fields'];
unset($formData['fields']);
}

// Get current logged in user.
$my = JFactory::getUser();

// Check if $userIdentifier is not set
if (empty($userIdentifier))
{
if ($formData['password'] == '')
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_REQUIRED_DATA_EMPTY_MESSAGE'));

return;
}

// Set default group if nothing is passed for group.
if (empty($formData['groups']))
{
$formData['groups'] = array($params->get("new_usertype", 2));
}

// Get a blank user object
$user = new JUser;
$me = $this->plugin->get('user');
$iAmSuperAdmin = $me->authorise('core.create');

// Create new user.
$response = $this->storeUser($user, $formData, 1);
$this->plugin->setResponse($response);

return;
}
else
if (!empty($userIdentifier))
{
// Get a user object
$user = $this->retriveUser($xidentifier, $userIdentifier);
$passedUserGroups = array();
$user = $this->retriveUser($userIdentifier);

// If user is already present then update it according to access.
if (!empty($user->id))
{
$iAmSuperAdmin = $my->authorise('core.admin');

// Check if regular user is tring to update himself.
if ($my->id == $user->id || $iAmSuperAdmin)
// Check if regular user is trying to update his/her own profile OR if user is superadmin
if ($me->id == $user->id || $iAmSuperAdmin)
{
// If present then update or else dont include.
// If password present then update password2 or else dont include.
if (!empty($formData['password']))
{
$formData['password2'] = $formData['password'];
}

// Add newly added groups and keep the old one as it is.
/*// Add newly added groups and keep the old one as it is.
if (!empty($formData['groups']))
{
$passedUserGroups['groups'] = array_unique(array_merge($user->groups, $formData['groups']));
}
$formData['groups'] = array_unique(array_merge($user->groups, $formData['groups']));
}*/

$response = $this->storeUser($user, $passedUserGroups);
$response = $this->storeUser($user, $formData);
$this->plugin->setResponse($response);

return;
Expand All @@ -112,35 +86,62 @@ public function post()
}
else
{
if ($fidentifier)
{
$user = new JUser;
ApiError::raiseError(400, JText::_('PLG_API_USERS_USER_NOT_FOUND_MESSAGE'));

if ($formData['password'] == '')
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_REQUIRED_DATA_EMPTY_MESSAGE'));
return;
}
}
// Check if $userIdentifier is not set - POST / CREATE user case
else
{
if (!$iAmSuperAdmin)
{
ApiError::raiseError(400, JText::_('JERROR_ALERTNOAUTHOR'));

return;
}
return;
}

// Set default group if nothing is passed for group.
if (empty($formData['groups']))
{
$formData['groups'] = array($params->get("new_usertype", 2));
}
// Validate required fields
if ($formData['username'] == '' || $formData['name'] == '' || $formData['email'] == '')
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_REQUIRED_DATA_EMPTY_MESSAGE'));

// Create new user.
$response = $this->storeUser($user, $formData, 1);
$this->plugin->setResponse($response);
return;
}

return;
}
else
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_USER_ABSENT_MESSAGE'));
// Set default group if nothing is passed for group.
if (empty($formData['groups']))
{
$formData['groups'] = array($params->get("new_usertype", 2));
}

return;
}
// Get a blank user object
$user = new JUser;

// Create new user.
$response = $this->storeUser($user, $formData, 1);
$this->plugin->setResponse($response);

return;
}
}

/**
* Funtion to remove sensitive user info fields like password
*
* @param Object &$user The user object.
*
* @return object|void $user
*
* @since 2.0.1
*/
protected function sanitizeUserFields(&$user)
{
foreach ($this->fieldsToSanitize as $f)
{
if (isset($user->{$f}))
{
unset($user->{$f});
}
}
}
Expand All @@ -154,27 +155,24 @@ public function post()
*/
public function get()
{
$input = JFactory::getApplication()->input;
$id = $input->get('id', 0, 'int');
$xidentifier = $input->server->get('HTTP_X_IDENTIFIER', '', 'String');
$input = JFactory::getApplication()->input;
$id = $input->get('id', 0, 'string');

/*
* If we have an id try to fetch the user
* @TODO write user field mapping logic here
*/
if ($id)
{
// Get a user object
$user = $this->retriveUser($xidentifier, $id);
// Get user object
$user = $this->retriveUser($id);

if (! $user->id)
if (!$user->id)
{
ApiError::raiseError(400, JText::_('PLG_API_USERS_USER_NOT_FOUND_MESSAGE'));

return;
}

$this->plugin->setResponse($user);
}
else
{
Expand All @@ -184,9 +182,11 @@ public function get()
{
ApiError::raiseError(400, JText::_('JERROR_ALERTNOAUTHOR'));
}

$this->plugin->setResponse($user);
}

$this->sanitizeUserFields($user);

$this->plugin->setResponse($user);
}

/**
Expand Down Expand Up @@ -224,8 +224,22 @@ private function getUserId($email)
private function storeUser($user, $formData, $isNew = 0)
{
$response = new stdClass;
$ignore = array();

// Ignore pasword field if not set to avoid warning on bind()
if (!isset($formData['password']))
{
$ignore[] = 'password';
}

if (!$user->bind($formData))
// In case of edit user, set formData->id as $user->id no matter what is passed in x-identifier
// Otherwise - it will try to create new user
if (!$isNew)
{
$formData['id'] = $user->id;
}

if (!$user->bind($formData, $ignore))
{
ApiError::raiseError(400, $user->getError());

Expand All @@ -239,6 +253,7 @@ private function storeUser($user, $formData, $isNew = 0)
return;
}

// Set user id to be returned
$response->id = $user->id;

if ($isNew)
Expand All @@ -262,16 +277,15 @@ private function storeUser($user, $formData, $isNew = 0)
*/
public function delete()
{
$app = JFactory::getApplication();
$userIdentifier = $app->input->get('id', 0, 'STRING');
$xidentifier = $app->input->server->get('HTTP_X_IDENTIFIER', '', 'String');
$app = JFactory::getApplication();
$userIdentifier = $app->input->get('id', 0, 'string');

$loggedUser = JFactory::getUser();

// Check if I am a Super Admin
$iAmSuperAdmin = $loggedUser->authorise('core.admin');

$userToDelete = $this->retriveUser($xidentifier, $userIdentifier);
$userToDelete = $this->retriveUser($userIdentifier);

if (!$userToDelete->id)
{
Expand Down Expand Up @@ -319,19 +333,21 @@ public function delete()
/**
* Function retriveUser for get user details depending upon the identifier.
*
* @param string $xidentifier Flag to differentiate the column value.
*
* @param string $userIdentifier username
*
* @return object $user Juser object if user exist otherwise std class.
*
* @since 2.0
*/
private function retriveUser($xidentifier, $userIdentifier)
private function retriveUser($userIdentifier)
{
$user = new stdClass;

switch ($xidentifier)
// Flag to differentiate the column value
$app = JFactory::getApplication();
$xIdentifier = $app->input->server->get('HTTP_X_IDENTIFIER', '', 'WORD');

switch ($xIdentifier)
{
case 'username':
$userId = JUserHelper::getUserId($userIdentifier);
Expand Down