Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 bundle create: fix build_dir in select and pack actions #1246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lituzou
Copy link

@lituzou lituzou commented Jan 14, 2025

tectonic is unable to find the build directory correctly due to the use of cli.build_dir instead of the local build_dir joined with bundle name.

This PR addresses this bug.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (ddca0b8) to head (c70239b).

Files with missing lines Patch % Lines
src/bin/tectonic/v2cli/commands/bundle/actions.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   46.20%   46.14%   -0.06%     
==========================================
  Files         186      186              
  Lines       66139    66138       -1     
==========================================
- Hits        30561    30521      -40     
- Misses      35578    35617      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant