Allow choice of reqwest or curl for HTTP backend #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 46.83% 46.83% -0.01%
==========================================
Files 130 130
Lines 59700 59639 -61
==========================================
- Hits 27963 27929 -34
+ Misses 31737 31710 -27
Continue to review full report at Codecov.
|
pkgw
force-pushed
the
curl-download-backend
branch
6 times, most recently
from
14f15b5 to
3716553
Compare
This will work towards making the HTTP backend pluggable between reqwest and curl, and who knows what else in the future.
And add a "null" backend in case no real web backends are enabled. (This could be reasonable for a customized use case where one knows that web bundles will never be needed.) Also add curl as an optional dependency, but don't implement it yet.
This was just a silly idea.
pkgw
force-pushed
the
curl-download-backend
branch
from
3716553 to
598d11a
Compare
pkgw
force-pushed
the
curl-download-backend
branch
from
a0bcf8b to
577f362
Compare
And rework the CI to build/test both with and without it.
pkgw
force-pushed
the
curl-download-backend
branch
from
577f362 to
83a48f6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing @malbarbo's #525 with a sub-crate to isolate the HTTP backend API.
Starting out as a draft, checking that we didn't break anything before adding the newcurlbackend.This will supersede #525 once it's ready.