Prevent crash in /forgot-password by safely accessing error response#738
Open
Siddhi-sahu wants to merge 2 commits into
Open
Prevent crash in /forgot-password by safely accessing error response#738Siddhi-sahu wants to merge 2 commits into
Siddhi-sahu wants to merge 2 commits into
Conversation
WalkthroughThe change updates the error handling logic in the forgot password page. Specifically, the code now uses optional chaining to safely access nested error properties and provides a default fallback error message. This prevents runtime crashes that could occur if the expected error structure is missing or undefined. There are no changes to exported or public entity declarations or signatures. Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an unhandled runtime error that occurred in the /forgot-password flow. The app was trying to read
error.response.data.params.errwithout checking ifresponseexists, which caused a crash whenresponsewas undefined (e.g., during a network failure).Closes #737
Before
The app crashed with:
After
Graceful error handling with a toast message instead of crashing.
Why
To avoid confusing crashes for users and ensure smoother UX in edge cases like network issues.
Changes
?.)'Something went wrong'if the expected message is unavailablesidenote
I looked through all of the code base, which was huge and found this one inconsistency, took me hours so i hope i can get an acknowledgement.
Summary by CodeRabbit