Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for custom bundle resolver backoff #8574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add configuration for custom bundle resolver backoff #8574

wants to merge 1 commit into from

Conversation

arewm
Copy link

@arewm arewm commented Feb 17, 2025

Changes

A bundle resolver is susceptible to flakes in network communication. In order to increase reliability, we can add backoff retries to mitigate transient issues.

Partially addresses #8571

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Enables the configuration of backoffs for a bundle resolver requests.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 17, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arewm / name: Andrew McNamara (0f94f03)

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2025
@tekton-robot
Copy link
Collaborator

Hi @arewm. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025
@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2025
@afrittoli
Copy link
Member

Thanks @arewm, for your PR! It would be nice to have some unit tests for the new code

@vdemeester
Copy link
Member

@arewm can you rebase ?

@arewm arewm force-pushed the retry-container-bundle-resolution branch 2 times, most recently from 90b84fa to c19b58e Compare March 19, 2025 02:04
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@arewm arewm force-pushed the retry-container-bundle-resolution branch 2 times, most recently from 5996323 to 09d8f6a Compare March 19, 2025 02:19
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/bundle/bundle.go 72.2% 71.1% -1.2
pkg/resolution/resolver/bundle/config.go Do not exist 84.8%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/bundle/bundle.go 72.2% 71.1% -1.2
pkg/resolution/resolver/bundle/config.go Do not exist 84.8%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/bundle/bundle.go 72.2% 71.1% -1.2
pkg/resolution/resolver/bundle/config.go Do not exist 84.8%

vdemeester
vdemeester approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @waveywaves

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@waveywaves
Copy link
Member

/assign

@arewm
Add configuration for custom bundle resolver backoff
0f94f03 
A bundle resolver is susceptible to flakes in network communication. In
order to increase reliability, we can add backoff retries to mitigate
transient issues.

While it may be possible to add a generic retry functionality around
resolvers, implementation will likely be simpler if the retry
functionality is isolated to the individual resolvers. Future work is
needed to add retries to git resolver requests.

Partially addresses tektoncd#8571

Signed-off-by: arewm <[email protected]>
@arewm arewm force-pushed the retry-container-bundle-resolution branch from 09d8f6a to 0f94f03 Compare March 19, 2025 14:37
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/bundle/bundle.go 72.2% 71.1% -1.2
pkg/resolution/resolver/bundle/config.go Do not exist 84.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmouel chmouel chmouel left review comments

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees

@waveywaves waveywaves

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arewm @tekton-robot @afrittoli @vdemeester @waveywaves @chmouel